Animation can now be disabled #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Basically props.animate is good idea. Setting staticRotation to zero will still draw the SVG for every Frame. I just moved the if block a few lines up. |
|
If I'm understanding the code correctly, it seems that |
|
That's a bug. See line 242. I will push a fix in a few seconds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @badzong , I've added the option to disable animation --
Instance.props.animate. Whenfalse, no callback loop.EDIT: Bear with me, made some dumb mistakes. Will update when resolved.
EDIT2: @badzong , all done. For now,
FuseBoxdoesn't let you set the script type.EDIT3: Just realized something. There is no need for a separate "animate" option as this is implied by staticRotation. Instead, the core logic added here can be used implicity when staticRotation is zero.