New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify webpack config to include angular2-template-loader #2

Merged
merged 1 commit into from Jul 23, 2018

Conversation

Projects
None yet
3 participants
@geocine
Copy link
Contributor

geocine commented Jul 21, 2018

as explained by @meDavid at #1 , the templates and styles are not resolved correctly, this PR resolves it

@geocine geocine changed the title #1 modify webpack config to include angular-template-loader modify webpack config to include angular-template-loader Jul 21, 2018

@geocine geocine changed the title modify webpack config to include angular-template-loader modify webpack config to include angular2-template-loader Jul 21, 2018

@meDavid

This comment has been minimized.

Copy link
Contributor

meDavid commented Jul 21, 2018

Thanks @geocine!

@@ -8,12 +8,17 @@ const webpackOptions = {
rules: [
{
test: /\.ts$/,
loaders: ['ts-loader', 'angular2-template-loader'],

This comment has been minimized.

@meDavid

meDavid Jul 21, 2018

Contributor

I think this file is part of @bahmutov/add-typescript-to-cypress npm bundle and copied from there on install.

This comment has been minimized.

@geocine

geocine Jul 21, 2018

Author Contributor

You may close this, I created a PR at @bahmutov/add-typescript-to-cypress

@bahmutov

This comment has been minimized.

Copy link
Owner

bahmutov commented Jul 23, 2018

I have set up Travis CI build for this project: https://travis-ci.org/bahmutov/cypress-angular-unit-test/builds

@bahmutov

This comment has been minimized.

Copy link
Owner

bahmutov commented Feb 17, 2019

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@bahmutov bahmutov added the released label Feb 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment