Miroslav Bajtoš
bajtos

Organizations

@coderetreatcz @IBM @strongloop @node-inspector @nodeschool @hkitcz
Aug 26, 2016
bajtos commented on pull request strongloop/loopback#2670
@bajtos

Nice! LGTM. Please wait for CI results to ensure tests are passing, and squash the commits before landing.

Aug 26, 2016
bajtos commented on pull request strongloop/loopback-swagger#54
@bajtos

@slnode ok to test

Aug 26, 2016
bajtos commented on pull request strongloop/loopback#2671
@bajtos

One last nit-pick, the change LGTM otherwise. Make sure to check the CI results, no further review is needed. Also please squash the commits before…

Aug 26, 2016
bajtos commented on pull request strongloop/loopback#2671
@bajtos

two empty lines, keep only one

Aug 26, 2016
bajtos opened pull request strongloop/loopback#2680
@bajtos
Update pre-release dependencies
1 commit with 2 additions and 2 deletions
Aug 26, 2016
Aug 26, 2016
@bajtos
Aug 26, 2016
Aug 26, 2016
bajtos commented on issue strongloop/loopback#2144
@bajtos

@boyd4y I don't think so. Can you rewrite your code to call modelInstance.updateAttribute('field', 'xx') instead?

Aug 26, 2016
@bajtos

To be honest, I don't know what's the expected behavior here. AFAICT, no real user complained about this so far, in which case I think it does not …

Aug 26, 2016
bajtos commented on pull request strongloop/loopback#2670
@bajtos

@Amir-61 is there a reasonably-easy way how to write a unit-test for this?

Aug 26, 2016
@bajtos
Add port independence
Aug 26, 2016
bajtos commented on pull request strongloop/loopback-sdk-android#108
@bajtos

Agreed.

Aug 26, 2016
bajtos commented on pull request strongloop/loopback#2671
@bajtos

@loay also please check why the tests have failed on some platforms.

Aug 26, 2016
bajtos commented on pull request strongloop/loopback#2671
@bajtos

@loay reviewed, PTAL

Aug 26, 2016
bajtos commented on pull request strongloop/loopback#2671
@bajtos

indentation is off, function should be indented with the same level as it. describe('...', it('...', function(done) { }): it('...', function(done) …

Aug 26, 2016
bajtos commented on pull request strongloop/loopback#2671
@bajtos

I am afraid the way how these three new tests are written may be prone to timing-based failures. What if "resetPasswordRequest" gets emitted while U…

Aug 26, 2016
bajtos commented on pull request strongloop/loopback#2679
@bajtos

@SubuIBM Thank you for the pull request. Please add a unit-test to verify the change and prevent regressions in the future. You can find existing t…

Aug 26, 2016
bajtos commented on pull request strongloop/loopback-workspace#316
@bajtos

One more nitpick, the patch LGTM otherwise. No more review is needed, please squash the commits before merging.

Aug 26, 2016
bajtos commented on pull request strongloop/loopback-workspace#316
@bajtos

Nitpick: expect(config).to.have.property('legacyExplorer', false) https://github.com/moll/js-must#beware-of-libraries-that-assert-on-property-access

Aug 26, 2016
@bajtos

LGTM.

Aug 26, 2016
@bajtos
Aug 26, 2016
@bajtos
Aug 26, 2016
@bajtos
bajtos deleted branch cleanup/memory-test-2x at strongloop/loopback-datasource-juggler
Aug 26, 2016
Aug 26, 2016
@bajtos
Aug 26, 2016
@bajtos
test/memory: remove dummy findOrCreate impl [2.x]
1 commit with 7 additions and 12 deletions