New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Space in Heading removes heading #1282

Open
jugdemon opened this Issue May 19, 2018 · 11 comments

Comments

Projects
None yet
4 participants
@jugdemon

jugdemon commented May 19, 2018

I have multiple spaces in the headings in my WikkaWiki. When Softaculous upgraded from 1.3.8 to 1.4, the headings disappear from the page. In the editing mode they are still existent, but inspecting them in the source code mode of the browser shows that they are never loaded from the server.

I assume that some change on back end after 1.3.8 makes it impossible to load headings with spaces inside.

I tested the behaviour for different headings and it always appears.

@bakoontz

This comment has been minimized.

Owner

bakoontz commented May 20, 2018

@jugdemon

This comment has been minimized.

jugdemon commented May 20, 2018

You can go to the same test page from my other issue: http://scholar.gruebel.io/test

Replace the currently present ======Test====== with ======Test test====== and store the page to see the header disappear.

@pataphysics

This comment has been minimized.

pataphysics commented May 27, 2018

I'm seeing the same thing: headings with spaces in them appear in editing mode but don't appear when displayed.

HOWEVER: If bold formatting is added to the heading, it does appear. So

==== test text ==== heading does not appear

==== ** test text ** ==== does.

@bakoontz bakoontz added this to the 1.4.1 milestone May 27, 2018

@bakoontz bakoontz self-assigned this May 27, 2018

@bakoontz bakoontz added the bug label May 27, 2018

@bakoontz

This comment has been minimized.

Owner

bakoontz commented May 27, 2018

I'm able to reproduce it. It's a bug related to #1274. If you have access to your Wikka install, you can replace line 46 in formatters/wakka.php with the following:

if (!defined('PATTERN_MATCH_HEADINGS')) define('PATTERN_MATCH_HEADINGS', '#^<(h[1-6])(.*?)>\s*?(.*)\s*?</\\1>$#s');

Tested with the following:

===Test Test===  
===**Test Test**===    
===  Test Test  ===    
===  **Test Test**  ===    

I'll include it in the 1.4.1 release. Thanks for the report!

@jugdemon

This comment has been minimized.

jugdemon commented May 28, 2018

@bakoontz When can we expect the release of 1.4.1? I am just trying to way my options, because while it is slightly annoying, I was thinking of just making the headers bold instead of meddling with the install. Softaculous responded so quickly to my request to upgrade to the newer version that I only expect a week delay after you release to get it installed.

Again, thanks for the effort. For now I am only consuming, but I am considering to contribute as this tool is amazing. When I am ready, what is the best way to contribute? Bug fixing, forking and feature implementing?

@pataphysics

This comment has been minimized.

pataphysics commented May 28, 2018

I replaced line 46 with the new code, and all headings with and w/o spaces are appearing. Thanks @bakoontz.

@bakoontz

This comment has been minimized.

Owner

bakoontz commented May 28, 2018

@bakoontz

This comment has been minimized.

Owner

bakoontz commented May 28, 2018

@pataphysics Quite welcome, thanks for confirming the fix works.

@jugdemon

This comment has been minimized.

jugdemon commented May 29, 2018

@bakoontz I did not mean to push a release, I was rather asking in terms of what is your current expected date for a release. For now I can live with invisible headers, especially since the information is still there while editing.

I think push access would be a nice start. I would start looking into some bugs, to get a feel of the code base and I'll follow your merge instruction once I actually fix something.

@bakoontz

This comment has been minimized.

Owner

bakoontz commented May 29, 2018

@ldemattos

This comment has been minimized.

ldemattos commented Dec 4, 2018

I replaced line 46 with the new code, and all headings with and w/o spaces are appearing. Thanks @bakoontz.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment