Fix(#219): split_high_level function to ignore delimiters inside single quotes #220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the split function would incorrectly split strings containing delimiters inside single quotes. this causes issue when splitting columns with default value that has ',' within it. Now, delimiters within single quotes are ignored, ensuring proper splitting behavior.
jayakarthik-jk
commented
Nov 20, 2025
Contributor
Author
jayakarthik-jk
left a comment
jayakarthik-jk
left a comment
There was a problem hiding this comment.
generated the fix using copilot.
Owner
|
Thanks a lot for the PR. Could you please also generate a unit-test for this function? |
- Test ignoring delimiters inside single quotes - Test ignoring delimiters inside parentheses - Test realistic SQL scenarios including ENUM, SET, DEFAULT values - Cover edge cases like empty strings and nested structures - All 14 tests passing
Contributor
Author
|
Done, generated the unit tests. |
jayakarthik-jk
deleted the
fix/split-high-level-ignore-quoted-delimiter
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix of #219
Previously, the split function would incorrectly split strings containing delimiters inside single quotes. this causes issue when splitting columns with default value that has ',' within it. Now, delimiters within single quotes are ignored, ensuring proper splitting behavior.