Added "shield" client mode for elastic v1: This is required to be com… #1228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…patible with elastic v2 In case of elastic v2, if someone wants to use shield, the client mode must be "shield". However, elastic v1 only uses "transport" for shield and gave error for "shield" mode in the config. The different config option was confusing if someone wanted to use both elastic v1 and v2 or just switched from v1 to v2 or vice versa. This patch fixes it, from now, if someone wants to use shield mode, he can give "shield" as client mode for both elastic v1 and v2. Signed-off-by: Zoltan Pallagi <pzoleex@gmail.com>
lbudai
approved these changes
Oct 19, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…patible with elastic v2
In case of elastic v2, if someone wants to use shield, the client mode must be "shield".
However, elastic v1 only uses "transport" for shield and gave error for "shield" mode in the config.
The different config option was confusing if someone wanted to use both elastic v1 and v2 or just switched from v1 to v2 or vice versa.
This patch fixes it, from now, if someone wants to use shield mode, he can give "shield" as client mode for both elastic v1 and v2.
Signed-off-by: Zoltan Pallagi pzoleex@gmail.com