Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not ship rabbitmq-c with syslog-ng (remove as submodule) #2052

Merged
merged 1 commit into from May 27, 2018

Conversation

Kokan
Copy link
Collaborator

@Kokan Kokan commented May 23, 2018

This removes the internal version of rabbitmq-c so its source won't be shipped with syslog-ng anymore.

At this point we are stuck with the current commit for rabbitmq-c, because it only supports cmake based build after this commit, the autotools have been dropped. The autotools probably won't be supported anymore, and I do not think that syslog-ng project should continue to support it either. Thus I am proposing to drop as a submodule and everybody that needs amqp just get themself as other dependencies.

Fixes #2051
Disclaimer: although it is not a real fix, I believe this is a way forward, and with this that ticket can be closed.

@kira-syslogng
Copy link
Contributor

Build SUCCESS

1 similar comment
@kira-syslogng
Copy link
Contributor

Build SUCCESS

.travis.yml Outdated
@@ -54,7 +55,7 @@ before_script:
--prefix=$HOME/install/syslog-ng
--with-ivykis=internal
--with-mongoc=internal
--with-librabbitmq=internal
--with-librabbitmq=system
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In configure.ac you dropped the whole option, so you can just delete the line.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, if it is a go I'll update this.

@algernon
Copy link
Contributor

I wholeheartedly support the idea! \o/

@bazsi
Copy link
Collaborator

bazsi commented May 23, 2018 via email

@czanik
Copy link
Contributor

czanik commented May 23, 2018

Hi,
I have to check it, but AFAIR, there is no RabbitMQ in CentOS/RHEL or EPEL (only in Fedora). And only the server, but no client in openSUSE (and SLES usually has a narrower selection of packages).

@czanik
Copy link
Contributor

czanik commented May 23, 2018

RHEL7 has librabbitmq 0.8.0 in the base repository.
RHEL6 has librabbitmq 0.5.2 in EPEL
SLES15 has no rabbitmq at all
openSUSE only has the rabbitmq server and Java client

Now submouldes are half baked, some dependency are added as submodule and some are not.
As the AMQP is not a core functionality, so it is not a requirement to compile syslog-ng.

Also this is the last commit, where the autotools are supported by rabbitmq-c, unless we include the cmake into the build (integrate with autotools) there is no way to update the submodule, thus no fix can came from upstream. That's really bad.

Signed-off-by: kokan <peter.kokai@balabit.com>
@Kokan Kokan force-pushed the remove-submodule-rabbitmq branch from b71984f to c055959 Compare May 23, 2018 20:23
@kira-syslogng
Copy link
Contributor

Build SUCCESS

@mitzkia
Copy link
Collaborator

mitzkia commented May 24, 2018

Could you please check and add librabbitmq-dev package into dbld's package lists.

@kira-syslogng
Copy link
Contributor

Build FAILURE

@lbudai
Copy link
Collaborator

lbudai commented May 27, 2018

OBS won't be a problem as I'm building the rabbitmq package inside OBS.

@lbudai
Copy link
Collaborator

lbudai commented May 27, 2018

@kira-syslogng retest this please

@kira-syslogng
Copy link
Contributor

Build SUCCESS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make of 3.15.1 fails tools/publish.c, subsequent make runs to completion (publish.c skipped?)
9 participants