Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leak redis connection #2383

Merged
merged 2 commits into from Oct 30, 2018
Merged

Leak redis connection #2383

merged 2 commits into from Oct 30, 2018

Conversation

Kokan
Copy link
Collaborator

@Kokan Kokan commented Oct 30, 2018

  • The redis destination leaked the connection at every reconnect and/or reload.
  • Removed the reconnect arg, that did not prevent reconnection (it is better to check if the connection is alive)

@Kokan
redis: connect use check_connection and remove reconnect arg
8f44d01 
Signed-off-by: Kokan <kokaipeter@gmail.com>
@Kokan
redis: fix leaking connection
292b46c 
Signed-off-by: Kokan <kokaipeter@gmail.com>
@Kokan
Copy link
Collaborator Author

Kokan commented Oct 30, 2018

@HanouaJ could you also test with this version ?

@kira-syslogng
Copy link
Contributor

Build SUCCESS

@furiel furiel merged commit 4208380 into syslog-ng:master Oct 30, 2018
@Kokan Kokan deleted the redis-leak branch October 30, 2018 14:43
@Kokan Kokan mentioned this pull request Oct 30, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrAnno MrAnno MrAnno approved these changes

@furiel furiel furiel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Kokan @kira-syslogng @MrAnno @furiel