New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syslog-ng@default: use pid file location on control socket #2489

Merged
merged 1 commit into from Jan 12, 2019

Conversation

Projects
None yet
5 participants
@andy9a9
Copy link
Contributor

andy9a9 commented Jan 11, 2019

When the pid file location was changed via --with-pidfile-dir= control socket was still pointing to /var/lib/syslog-ng even if they are using same path definition.

syslog-ng@default: use pid file location on control socket
Regarding to lib/syslog-ng.h file, pid and control files needs to placed
on the same location.

#define PATH_PIDFILE            SYSLOG_NG_PATH_PIDFILEDIR "/syslog-ng.pid"
#define PATH_CONTROL_SOCKET     SYSLOG_NG_PATH_PIDFILEDIR "/syslog-ng.ctl"

Signed-off-by: Andrej Valek <andrej.valek@siemens.com>
@kira-syslogng

This comment has been minimized.

Copy link
Contributor

kira-syslogng commented Jan 11, 2019

This user does not have permission to start the build. Can one of the admins verify this patch and start the build?
(admin: you have the next options (make sure you checked the code):
"ok to test" to accept this pull request (and further changes) for testing
"test this please" for a one time test run
do nothing -> CI won't start)

1 similar comment
@kira-syslogng

This comment has been minimized.

Copy link
Contributor

kira-syslogng commented Jan 11, 2019

This user does not have permission to start the build. Can one of the admins verify this patch and start the build?
(admin: you have the next options (make sure you checked the code):
"ok to test" to accept this pull request (and further changes) for testing
"test this please" for a one time test run
do nothing -> CI won't start)

@Kokan

This comment has been minimized.

Copy link
Member

Kokan commented Jan 11, 2019

@kira-syslogng ok to test

@kira-syslogng

This comment has been minimized.

Copy link
Contributor

kira-syslogng commented Jan 11, 2019

Build SUCCESS

@gaborznagy gaborznagy self-requested a review Jan 11, 2019

@gaborznagy

This comment has been minimized.

Copy link
Contributor

gaborznagy commented Jan 11, 2019

Hi @andy9a9!

Thanks for your contribution!

Can I ask which distribution do you use for syslog-ng?
Do you use unofficial builds or you build it from source?

Because the packaging for various distributions can be different and the service file you edited maybe not used in those distros.
Nevertheless what you have changed follows a convention (what you have found in lib/syslog-ng.h)!

@andy9a9

This comment has been minimized.

Copy link
Contributor

andy9a9 commented Jan 11, 2019

Hi @gaborznagy !
I am building syslog-ng with Yocto (Open-embedded) distribution. Somebody change the pid file location. I was wondering, that .ctl socket location was also changed. So I was searching a little bit about and found this issue.

@MrAnno

MrAnno approved these changes Jan 12, 2019

@Kokan Kokan merged commit 9554237 into balabit:master Jan 12, 2019

4 checks passed

Kira-starter Build SUCCESS
Details
LGTM analysis: C/C++ No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@andy9a9 andy9a9 deleted the andy9a9:fix/ctl branch Jan 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment