Wrap object creation. #501
Conversation
This change was one way that we weren't in line with the spec.
|
are we also going to have scenarios for when using just the application/json content type or for form content type, where wrapping the content of the request is not required? |
|
Yeah, form content type tests would be good. I'll make an issue that we're missing those. |
…sted as some json instead of www-form
|
Restarting the build, let's see how this goes. |
|
Can you rebase this? I'm pretty sure that's why the tests still fail. |
|
@steveklabnik was that last comment meant for me? |
|
yes. |
|
ping @matthewfl |
Conflicts: features/checkout_flow.feature features/credits.feature features/rest/bank_accounts.feature features/rest/cards.feature features/rest/customers.feature features/rest/debits.feature features/rest/refunds.feature
|
These tests are still failing because it says it isn't JSON. |
|
"it"? the last time I worked on this the problem was the httpparty was passing everything as x-www-form instead of json |
|
Look at the error message. No clue, looks good to me. :( |
|
There should be one tests that is failing, however it is unrelated to the wrapping of json and instead related to the address cracking issue which has already been noted |
|
@matthewfl is this ready 2 go? |
|
woot! thx @matthewfl |
This change was one way that we weren't in line with the spec.
/cc @matthewfl