Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Bank Account Debits Always Return Pending States Unless They Fail #669

Merged
merged 1 commit into from

4 participants

@cieplak

No description provided.

Patrick Cieplak fix failing spec f062e1f
@cieplak

This should fix this failing spec:
image

@cieplak cieplak changed the title from Bank Account Debits Always Return Pending States to Bank Account Debits Always Return Pending States Unless the Fail
@cieplak cieplak changed the title from Bank Account Debits Always Return Pending States Unless the Fail to Bank Account Debits Always Return Pending States Unless They Fail
@mjallday
Owner

yes, this scenario uses a test bank account number that should transition transactions to pending. Fixes #668

@matthewfl

was this wrong to begin with/is this using a bank account number that should have a status of pending or is this one suppose to be succeeded

@mjallday
Owner

lgtm

@matin
Owner

@cieplak You can't fix a scenario by changing the scenario. This scenario used to pass. There was a regression.

@mjallday
Owner

@matin if you look at the link I provided above, the scenario uses a bank account that's supposed to transition all txns created with it to the PENDING state.

Since I've been away I guess that what may have happened is that someone fixed the bug with test bank account numbers not transitioning correctly and this is what caused the scenario (which was incorrectly written but passed because of a bug) to fail.

If the scenario needs the bank account's transaction to be in the SUCCEEDED state then the fixture should use a different bank account number.

@matin
Owner

Does that mean there was a bug in the scenario before?

@mjallday
Owner

The way it was written depended on broken behavior. If you view that as a bug then yes :)

@matin
Owner

Makes sense. It looks like the scenario was purely written to match the existing behavior of the API: e866535

@matin matin merged commit dbcdf46 into from
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jul 23, 2014
  1. fix failing spec

    Patrick Cieplak authored
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  features/debits.feature
View
2  features/debits.feature
@@ -162,7 +162,7 @@ Feature: Debit a card or bank account
And the response is valid according to the "debits" schema
And the fields on these debits match:
"""
- { "status": "succeeded" }
+ { "status": "pending" }
"""
Scenario: Debits to unverified bank accounts fail
Something went wrong with that request. Please try again.