Bank Account Debits Always Return Pending States Unless They Fail #669

Merged
merged 1 commit into from Jul 23, 2014

Projects

None yet

4 participants

@cieplak
cieplak commented Jul 23, 2014

No description provided.

Patrick Cieplak fix failing spec f062e1f
cieplak commented Jul 23, 2014

This should fix this failing spec:
image

@cieplak cieplak changed the title from Bank Account Debits Always Return Pending States to Bank Account Debits Always Return Pending States Unless the Fail Jul 23, 2014
@cieplak cieplak changed the title from Bank Account Debits Always Return Pending States Unless the Fail to Bank Account Debits Always Return Pending States Unless They Fail Jul 23, 2014
Contributor

yes, this scenario uses a test bank account number that should transition transactions to pending. Fixes #668

@matthewfl

was this wrong to begin with/is this using a bank account number that should have a status of pending or is this one suppose to be succeeded

Contributor

lgtm

@matin
Owner
matin commented on f062e1f Jul 23, 2014

@cieplak You can't fix a scenario by changing the scenario. This scenario used to pass. There was a regression.

Contributor

@matin if you look at the link I provided above, the scenario uses a bank account that's supposed to transition all txns created with it to the PENDING state.

Since I've been away I guess that what may have happened is that someone fixed the bug with test bank account numbers not transitioning correctly and this is what caused the scenario (which was incorrectly written but passed because of a bug) to fail.

If the scenario needs the bank account's transaction to be in the SUCCEEDED state then the fixture should use a different bank account number.

Owner
matin commented Jul 23, 2014

Does that mean there was a bug in the scenario before?

Contributor

The way it was written depended on broken behavior. If you view that as a bug then yes :)

Owner
matin commented Jul 23, 2014

Makes sense. It looks like the scenario was purely written to match the existing behavior of the API: e866535

@matin matin merged commit dbcdf46 into master Jul 23, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment