Display error messages in modal #846

Merged
merged 7 commits into from Dec 20, 2013

Conversation

Projects
None yet
2 participants
@kyungmin
Contributor

kyungmin commented Dec 18, 2013

Fixes #604

static/less/modals.less
+ .alert-error {
+ background-color: transparent;
+ border-color: transparent;
+ color: #D9002A;

This comment has been minimized.

@mjallday

mjallday Dec 18, 2013

Contributor

all colors should be referenced as variables from variables.less

@mjallday

mjallday Dec 18, 2013

Contributor

all colors should be referenced as variables from variables.less

@mjallday

This comment has been minimized.

Show comment
Hide comment
@mjallday

mjallday Dec 18, 2013

Contributor

This is a good start. Don't forget to write tests to ensure that this functionality works as expected.

Contributor

mjallday commented Dec 18, 2013

This is a good start. Don't forget to write tests to ensure that this functionality works as expected.

@kyungmin

This comment has been minimized.

Show comment
Hide comment
@kyungmin

kyungmin Dec 19, 2013

Contributor

@mjallday can you review this please?

Contributor

kyungmin commented Dec 19, 2013

@mjallday can you review this please?

@mjallday

This comment has been minimized.

Show comment
Hide comment
@mjallday

mjallday Dec 19, 2013

Contributor

@kyungmin looks good, can you please remove static/less/modals.less.orig from the pull request? we don't need that.

Contributor

mjallday commented Dec 19, 2013

@kyungmin looks good, can you please remove static/less/modals.less.orig from the pull request? we don't need that.

@kyungmin

This comment has been minimized.

Show comment
Hide comment
Contributor

kyungmin commented Dec 19, 2013

@kyungmin

This comment has been minimized.

Show comment
Hide comment
@kyungmin

kyungmin Dec 20, 2013

Contributor

Now the last build failed because the reverting step replaced whitespaces with tabs in some files. Not sure if there's any easy way to fix this..

Contributor

kyungmin commented Dec 20, 2013

Now the last build failed because the reverting step replaced whitespaces with tabs in some files. Not sure if there's any easy way to fix this..

@mjallday mjallday merged commit fb03f42 into balanced:master Dec 20, 2013

1 check failed

default The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment