New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expands content section of dashboard #922

Merged
merged 8 commits into from Jan 31, 2014

Conversation

Projects
None yet
3 participants
@rserna2010
Contributor

rserna2010 commented Jan 23, 2014

Fix #746

@@ -102,7 +102,7 @@
// content is our main content area where most data for the current page is
// displayed
@pageTitleWidth: 885px;
@pageTitleWidth: @gridGutterWidth * 65;

This comment has been minimized.

@mjallday

mjallday Jan 23, 2014

Contributor

what magic is this?! how did you get 65?

@mjallday

mjallday Jan 23, 2014

Contributor

what magic is this?! how did you get 65?

This comment has been minimized.

@rserna2010

rserna2010 Jan 24, 2014

Contributor

Changed the width to 975 to maintain consistency with the width of the
content. 15 * 65 = 975. Boom math son. I can make it 965 if you want.

On Thu, Jan 23, 2014 at 3:24 PM, Marshall Jones notifications@github.comwrote:

In static/less/variables.less:

@@ -102,7 +102,7 @@

// content is our main content area where most data for the current page is
// displayed
-@pageTitleWidth: 885px;
+@pageTitleWidth: @gridGutterWidth * 65;

what magic is this?! how did you get 65?


Reply to this email directly or view it on GitHubhttps://github.com/balanced/balanced-dashboard/pull/922/files#r9134876
.

714-417-2727
rserna2010@gmail.com

@rserna2010

rserna2010 Jan 24, 2014

Contributor

Changed the width to 975 to maintain consistency with the width of the
content. 15 * 65 = 975. Boom math son. I can make it 965 if you want.

On Thu, Jan 23, 2014 at 3:24 PM, Marshall Jones notifications@github.comwrote:

In static/less/variables.less:

@@ -102,7 +102,7 @@

// content is our main content area where most data for the current page is
// displayed
-@pageTitleWidth: 885px;
+@pageTitleWidth: @gridGutterWidth * 65;

what magic is this?! how did you get 65?


Reply to this email directly or view it on GitHubhttps://github.com/balanced/balanced-dashboard/pull/922/files#r9134876
.

714-417-2727
rserna2010@gmail.com

This comment has been minimized.

@mjallday

mjallday Jan 24, 2014

Contributor

image
Clearly I do not.

@mjallday

mjallday Jan 24, 2014

Contributor

image
Clearly I do not.

@mjallday

This comment has been minimized.

Show comment
Hide comment
@mjallday

mjallday Jan 24, 2014

Contributor

@kyungmin @dmdj03 can you please review this change together and make sure this looks correct?

Contributor

mjallday commented Jan 24, 2014

@kyungmin @dmdj03 can you please review this change together and make sure this looks correct?

@ghost ghost assigned kyungmin Jan 24, 2014

@mjallday

This comment has been minimized.

Show comment
Hide comment
@mjallday

mjallday Jan 24, 2014

Contributor

@rserna2010 the tests appear to be failing. can you take a look at that?

Contributor

mjallday commented Jan 24, 2014

@rserna2010 the tests appear to be failing. can you take a look at that?

@rserna2010

This comment has been minimized.

Show comment
Hide comment
@rserna2010

rserna2010 Jan 24, 2014

Contributor

@mjallday tests passing @kyungmin can you please review

Contributor

rserna2010 commented Jan 24, 2014

@mjallday tests passing @kyungmin can you please review

@kyungmin

This comment has been minimized.

Show comment
Hide comment
@kyungmin

kyungmin Jan 24, 2014

Contributor

@rserna2010,
@dmdj03 and I found that the following pages don't have the same width:

  • Invoices tab: needs less padding on the right
  • Add/Remove marketplaces (/marketplaces)
  • Register marketplace (/marketplaces/apply)
Contributor

kyungmin commented Jan 24, 2014

@rserna2010,
@dmdj03 and I found that the following pages don't have the same width:

  • Invoices tab: needs less padding on the right
  • Add/Remove marketplaces (/marketplaces)
  • Register marketplace (/marketplaces/apply)
@rserna2010

This comment has been minimized.

Show comment
Hide comment
@rserna2010

rserna2010 Jan 25, 2014

Contributor

@kyungmin want to give it a final gander

Contributor

rserna2010 commented Jan 25, 2014

@kyungmin want to give it a final gander

@kyungmin

This comment has been minimized.

Show comment
Hide comment
@kyungmin

kyungmin Jan 27, 2014

Contributor

@rserna2010 Looks great!

Contributor

kyungmin commented Jan 27, 2014

@rserna2010 Looks great!

@rserna2010

This comment has been minimized.

Show comment
Hide comment
@rserna2010

rserna2010 Jan 31, 2014

Contributor

@mjallday ping

Contributor

rserna2010 commented Jan 31, 2014

@mjallday ping

mjallday added a commit that referenced this pull request Jan 31, 2014

Merge pull request #922 from rserna2010/dashboard-fixes
Expands content section of dashboard

@mjallday mjallday merged commit c23f224 into balanced:master Jan 31, 2014

1 check passed

default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment