Add support for JCB and Diners Club cards. #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the [documentation](https://support.balancedpayments.com/hc/en-us/articles/200319895-Does-Balanced-accept-JCB-and-Diners-Club-cards) Balanced supports JCB and Diners, but they weren't recognized by balanced-js. Added using test card numbers found elsewhere online; these should be changed if there are specific numbers you support.
|
this looks good to me, but are you using rev1 of the api? |
|
I pulled the branch off of |
matthewfl
added a commit
that referenced
this pull request
Jan 16, 2014
Add support for JCB and Diners Club cards.
|
Thanks from fareharbor.com! |
|
@matthewfl do you have the power to bump the version and deploy? @zachsnow shoot us an email to support@balancedpayments.com if you'd like some swag for helping us improve the library. |
|
this is live on rev0 and rev1 https://js.balancedpayments.com/v1/balanced.js |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
According to the documentation Balanced supports JCB and Diners, but they weren't recognized by balanced-js. I added support for their prefixes based on Wikipedia. Also added test card numbers found elsewhere online; these should be changed if there are specific numbers you support.
-Zach