Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed incorrect method name from v1 to v1.1 changeover #78

Merged
merged 1 commit into from
Jan 14, 2014

Conversation

icook
Copy link
Contributor

@icook icook commented Jan 14, 2014

This was figured out from experimentation with the v1.1 library, so I'm not sure if it's 100% correct.

@mjallday
Copy link
Contributor

Great catch.

i think this is why we need a generation tool rather than copying the rev0 code.

@icook shoot us an email to support@balancedpayments.com if you'd like some swag to say thanks :)

mjallday added a commit that referenced this pull request Jan 14, 2014
Fixed incorrect method name from v1 to v1.1 changeover
@mjallday mjallday merged commit fca6685 into balanced:1.1 Jan 14, 2014
@mahmoudimus
Copy link
Contributor

@icook you sure you want to try rev 1.1 ;) ? if you are, I'll assign @remear to help see how you use it to work through any warts. Also happy to feature you on our upcoming blog release. We're relatively close to releasing it publicly.

@mahmoudimus
Copy link
Contributor

@mjallday why is this get - can we change this to retrieve?

@mjallday
Copy link
Contributor

@mahmoudimus it's the wac library, not the python client.

@mahmoudimus
Copy link
Contributor

that should be fixed before we release -- at least alias it to retrieve for now.

@icook
Copy link
Contributor Author

icook commented Jan 14, 2014

Actually sent an email earlier today about using v1.1. We're probably at least a month away from release, but we could definitely put a coming soon page up or something...

We're looking at v1.1 because we are handling Card/Bank Accounts abstraction from users on our end and I'd like to make debits independent of Customer objects.

@mjallday
Copy link
Contributor

@icook after discussions we're going to go the fetch route to help differentiate between the HTTP verb GET and the actual fetching of the resource. .get will continue to work but going forward the documentation for 1.1 clients will refer to a fetch method.

we've updated the docs and client library to reflect this.

thanks for bringing this up and please continue to provide feedback on 1.1, it's really valuable to us :).

@icook
Copy link
Contributor Author

icook commented Jan 16, 2014

Thanks for the notice, I'll change my stuff accordingly. I'll definitely let you know if I find any other quirks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants