Skip to content

Sor fix unwrap rates internally #2416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 30, 2025
Merged

Sor fix unwrap rates internally #2416

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8504569
SOR - Fix unwrapRates scaling
brunoguerios Oct 30, 2025
2a2ea8a
Add changeset
brunoguerios Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/stupid-moose-develop.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'backend': patch
---

SOR - Fix unwrapRates scaling
5 changes: 2 additions & 3 deletions modules/sor/utils/data.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { Cache } from 'memory-cache';
import { Address, parseUnits } from 'viem';
import { Address, parseEther, parseUnits } from 'viem';
import { Chain, PrismaPoolType, PrismaToken } from '@prisma/client';

import { prisma } from '../../../prisma/prisma-client';
Expand Down Expand Up @@ -253,7 +253,6 @@ export async function getBufferPoolsFromDBPools(pools: SORDbPool[], chain: Chain
// check if underlying token exists in the database
const underlyingToken = tokensMap[poolToken.token.underlyingTokenAddress];
if (underlyingToken) {
const unwrapRateDecimals = 18 - poolToken.token.decimals + underlyingToken.decimals;
bufferPools.push({
poolId: pool.id,
address: poolToken.address.toLowerCase() as Address,
Expand All @@ -269,7 +268,7 @@ export async function getBufferPoolsFromDBPools(pools: SORDbPool[], chain: Chain
balance: parseUnits(poolToken.token.bufferBalanceUnderlying, underlyingToken.decimals),
},
poolType: 'Buffer',
unwrapRate: parseUnits(poolToken.token.unwrapRate, unwrapRateDecimals),
unwrapRate: parseEther(poolToken.token.unwrapRate), // the way we store rates already takes into account main/underlying decimals differences
maxWithdraw: parseUnits(poolToken.token.maxWithdraw, poolToken.token.decimals),
maxDeposit: parseUnits(poolToken.token.maxDeposit, poolToken.token.decimals),
});
Expand Down