From b31f3698e684277be0cec120eb805f66d0af3788 Mon Sep 17 00:00:00 2001 From: mkflow27 Date: Tue, 29 Jul 2025 08:06:34 +0200 Subject: [PATCH 1/2] review: add initial review scaffold --- erc4626/FelixUSDT0Erc4626VaultReview29bb.md | 30 +++++++++++++++++++ erc4626/registry.json | 11 +++++++ .../FelixUSDT0RateProviderReview7662.md | 29 ++++++++++++++++++ rate-providers/registry.json | 9 ++++++ 4 files changed, 79 insertions(+) create mode 100644 erc4626/FelixUSDT0Erc4626VaultReview29bb.md create mode 100644 rate-providers/FelixUSDT0RateProviderReview7662.md diff --git a/erc4626/FelixUSDT0Erc4626VaultReview29bb.md b/erc4626/FelixUSDT0Erc4626VaultReview29bb.md new file mode 100644 index 00000000..cd4d0542 --- /dev/null +++ b/erc4626/FelixUSDT0Erc4626VaultReview29bb.md @@ -0,0 +1,30 @@ + +# Rate Provider: FelixUSDT0 rate provider + +## Details +This report was autogenerated on 29/07/2025. + +- Deployed at: + - [HyperEVM:0xfc5126377f0efc0041c0969ef9ba903ce67d151e](https://hyperevmscan.io/address/0xfc5126377f0efc0041c0969ef9ba903ce67d151e) +- Audit report(s): + - [Audits](https://docs.kinetiq.xyz/contracts-and-audits) + +## Context +Felix is a suite of on‑chain borrowing and lending products running on Hyperliquid L1. Our goal is to let anyone unlock liquidity or earn yield in a secure, risk‑adjusted, and friction‑free way. +## Review Checklist: Bare Minimum Compatibility +Each of the items below represents an absolute requirement for the Rate Provider. If any of these is unchecked, the Rate Provider is unfit to use. + +- [ ] Tests based on the [balancer-v3-monorepo](https://github.com/balancer/balancer-v3-monorepo/tree/main/pkg/vault/test/foundry/fork) pass for the given ERC4626 vaults, which can be found [here](https://github.com/balancer/balancer-v3-erc4626-tests/tree/main/test). +- [x] The required Vault implements the required operational ERC4626 Interface + +### Administrative Privileges +- [ ] The ERC4626 Vault is upgradeable** (e.g., via a proxy architecture). +- [ ] Other contracts which are part of the `mint` callchain are upgradeable**. You can find more information + about the involved contracts in this [tenderly simulation](simulating failed.) + +## Conclusion +**Summary judgment: USABLE/UNUSABLE** + +** upgradeable in this context means that: +- The contract is a proxy contract with an implementation sourced from Etherscan. + diff --git a/erc4626/registry.json b/erc4626/registry.json index cdf05fff..525e764f 100644 --- a/erc4626/registry.json +++ b/erc4626/registry.json @@ -1885,6 +1885,17 @@ "canUseBufferForSwaps": false, "useUnderlyingForAddRemove": true, "useWrappedForAddRemove": true + }, + "0xfc5126377f0efc0041c0969ef9ba903ce67d151e": { + "asset": "0xB8CE59FC3717ada4C02eaDF9682A9e934F625ebb", + "name": "FelixUSDT0Erc4626Vault.md", + "summary": "", + "review": "./FelixUSDT0Erc4626VaultReview29bb.md", + "warnings": [], + "upgradeableComponents": [], + "canUseBufferForSwaps": "", + "useUnderlyingForAddRemove": "", + "useWrappedForAddRemove": "" } } } diff --git a/rate-providers/FelixUSDT0RateProviderReview7662.md b/rate-providers/FelixUSDT0RateProviderReview7662.md new file mode 100644 index 00000000..dff9e61b --- /dev/null +++ b/rate-providers/FelixUSDT0RateProviderReview7662.md @@ -0,0 +1,29 @@ + +# Rate Provider: FelixUSDT0 rate provider + +## Details +This report was autogenerated on 28/07/2025. + +- Deployed at: + - [HyperEVM:0x762c3B8e276A6Da1068443837384AcCa68C3536C](https://hyperevmscan.io/address/0x762c3B8e276A6Da1068443837384AcCa68C3536C) +- Audit report(s): + - [Audits](https://docs.kinetiq.xyz/contracts-and-audits) + +## Context +Felix is a suite of on‑chain borrowing and lending products running on Hyperliquid L1. Our goal is to let anyone unlock liquidity or earn yield in a secure, risk‑adjusted, and friction‑free way. +## Review Checklist: Bare Minimum Compatibility +Each of the items below represents an absolute requirement for the Rate Provider. If any of these is unchecked, the Rate Provider is unfit to use. + +- [x] Implements the [`IRateProvider`](https://github.com/balancer/balancer-v2-monorepo/blob/bc3b3fee6e13e01d2efe610ed8118fdb74dfc1f2/pkg/interfaces/contracts/pool-utils/IRateProvider.sol) interface. +- [x] `getRate` returns an 18-decimal fixed point number (i.e., 1 == 1e18) regardless of underlying token decimals. + +### Administrative Privileges +- [ ] The Rate Provider is upgradeable** (e.g., via a proxy architecture). +- [ ] Other contracts which are part of the `getRate` callchain are upgradeable**. + +## Conclusion +**Summary judgment: USABLE** + +** upgradeable in this context means that: +- The contract is a proxy contract with an implementation sourced from Etherscan and the proxy emitted an "Upgraded" event. + diff --git a/rate-providers/registry.json b/rate-providers/registry.json index bb82b409..ef59689b 100644 --- a/rate-providers/registry.json +++ b/rate-providers/registry.json @@ -5178,6 +5178,15 @@ "implementationReviewed": "0x4376c06d866557fac5d0b5813526639c403bfcf5" } ] + }, + "0x762c3B8e276A6Da1068443837384AcCa68C3536C": { + "asset": "0xfc5126377f0efc0041c0969ef9ba903ce67d151e", + "name": "FelixUSDT0RateProvider.md", + "summary": "safe", + "review": "./FelixUSDT0RateProviderReview7662.md", + "warnings": [], + "factory": "", + "upgradeableComponents": [] } } } From 065ad101d202c94213af321212ac23753581c02e Mon Sep 17 00:00:00 2001 From: mkflow27 Date: Tue, 29 Jul 2025 08:15:12 +0200 Subject: [PATCH 2/2] review: add review data --- erc4626/FelixUSDT0Erc4626VaultReview29bb.md | 5 +++-- erc4626/registry.json | 8 ++++---- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/erc4626/FelixUSDT0Erc4626VaultReview29bb.md b/erc4626/FelixUSDT0Erc4626VaultReview29bb.md index cd4d0542..9b44d7d1 100644 --- a/erc4626/FelixUSDT0Erc4626VaultReview29bb.md +++ b/erc4626/FelixUSDT0Erc4626VaultReview29bb.md @@ -14,7 +14,7 @@ Felix is a suite of on‑chain borrowing and lending products running on Hyperli ## Review Checklist: Bare Minimum Compatibility Each of the items below represents an absolute requirement for the Rate Provider. If any of these is unchecked, the Rate Provider is unfit to use. -- [ ] Tests based on the [balancer-v3-monorepo](https://github.com/balancer/balancer-v3-monorepo/tree/main/pkg/vault/test/foundry/fork) pass for the given ERC4626 vaults, which can be found [here](https://github.com/balancer/balancer-v3-erc4626-tests/tree/main/test). +- [x] Tests based on the [balancer-v3-monorepo](https://github.com/balancer/balancer-v3-monorepo/tree/main/pkg/vault/test/foundry/fork) pass for the given ERC4626 vaults, which can be found [here](https://github.com/balancer/balancer-v3-erc4626-tests/tree/main/test). - [x] The required Vault implements the required operational ERC4626 Interface ### Administrative Privileges @@ -23,7 +23,8 @@ Each of the items below represents an absolute requirement for the Rate Provider about the involved contracts in this [tenderly simulation](simulating failed.) ## Conclusion -**Summary judgment: USABLE/UNUSABLE** +**Summary judgment: USABLE** +The passing fork tests can be found at: https://github.com/balancer/balancer-v3-erc4626-tests/pull/75 ** upgradeable in this context means that: - The contract is a proxy contract with an implementation sourced from Etherscan. diff --git a/erc4626/registry.json b/erc4626/registry.json index 525e764f..e00848df 100644 --- a/erc4626/registry.json +++ b/erc4626/registry.json @@ -1889,13 +1889,13 @@ "0xfc5126377f0efc0041c0969ef9ba903ce67d151e": { "asset": "0xB8CE59FC3717ada4C02eaDF9682A9e934F625ebb", "name": "FelixUSDT0Erc4626Vault.md", - "summary": "", + "summary": "safe", "review": "./FelixUSDT0Erc4626VaultReview29bb.md", "warnings": [], "upgradeableComponents": [], - "canUseBufferForSwaps": "", - "useUnderlyingForAddRemove": "", - "useWrappedForAddRemove": "" + "canUseBufferForSwaps": true, + "useUnderlyingForAddRemove": true, + "useWrappedForAddRemove": true } } }