New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot find module 'sails-redis' error #3

Closed
rdodev opened this Issue Jun 27, 2013 · 13 comments

Comments

7 participants
@rdodev
Copy link

rdodev commented Jun 27, 2013

Followed instructions as per Custom Adapters tutorial to add redis support, to no avail.

I then tried to install locally and globally via npm, same error.

Not sure what step I could be missing, but I'm stuck.

Both 'disk' and 'mysql' adapter seem to work as inteded.

@carlodicelico

This comment has been minimized.

Copy link

carlodicelico commented Jun 27, 2013

Would you mind pasting in a full stack trace if there is one?

@rdodev

This comment has been minimized.

Copy link
Author

rdodev commented Jun 27, 2013

macmini-4053:demo rdodev$ sails lift --dev
 debug: Starting server in /Users/rdodev/Code/sails/demo...

 module.js:340
    throw err;
   ^
 Error: Cannot find module '/Users/rdodev/Code/sails/demo/node_modules/sails-redis'    at     Function.Module._resolveFilename (module.js:338:15)    at Function.Module._load (module.js:280:25)
   at Module.require (module.js:364:17)
   at require (module.js:380:17)
    at requireAdapter (/usr/local/share/npm/lib/node_modules/sails/lib/waterline/index.js:149:22)
    at /usr/local/share/npm/lib/node_modules/sails/lib/waterline/index.js:134:41
    at forOwn (/usr/local/share/npm/lib/node_modules/sails/node_modules/lodash/dist/lodash.js:1106:15)
    at Function.forEach (/usr/local/share/npm/lib/node_modules/sails/node_modules/lodash/dist/lodash.js:2336:9)
    at getMissingAdapters (/usr/local/share/npm/lib/node_modules/sails/lib/waterline/index.js:116:5)
    at Object.module.exports [as waterline] (/usr/local/share/npm/lib/node_modules/sails/lib/waterline/index.js:54:23)
    at loadSails (/usr/local/share/npm/lib/node_modules/sails/lib/sails.js:216:8)
    at Object.liftSails [as lift] (/usr/local/share/npm/lib/node_modules/sails/lib/sails.js:60:2)
    at module.exports (/usr/local/share/npm/lib/node_modules/sails/bin/lift.js:93:27)
    at Object.<anonymous> (/usr/local/share/npm/lib/node_modules/sails/bin/sails.js:49:22)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Function.Module.runMain (module.js:497:10)
    at startup (node.js:119:16)
    at node.js:901:3
@xdissent

This comment has been minimized.

Copy link
Member

xdissent commented Jul 9, 2013

The sails-redis module that's currently published on npm doesn't actually include the adapter source at all. npm uses the .gitignore file in absence of a .npmignore, so perhaps differences in how npm and git match ignore patterns is responsible.

@nathanleclaire

This comment has been minimized.

Copy link

nathanleclaire commented Dec 27, 2013

+1 I am getting this issue. The npm module installed with npm install sails-redis only includes README.md, node_modules, and package.json.

@nathanleclaire

This comment has been minimized.

Copy link

nathanleclaire commented Dec 27, 2013

To install this package, you can run npm install git+https://balderdashy@github.com/balderdashy/sails-redis.git.

Still, the npm version should definitely be up to date... I'm looking into to how to fix it.

I'd like to help with maintenance / development of this module if you need help.

@vanetix

This comment has been minimized.

Copy link
Member

vanetix commented Dec 29, 2013

The current version is more or less a proof of concept, I'll start devoting some more time to it in the new year. Right now it's functional, but many waterline-adapter-tests fail.

@mikermcneil

This comment has been minimized.

Copy link
Member

mikermcneil commented Jan 3, 2014

@vanetix hey man let me know when you want me to push it out to npm- I'll add you on it as well if you'd like

@mikermcneil

This comment has been minimized.

Copy link
Member

mikermcneil commented Jan 3, 2014

@vanetix (PS- we'll be working on this a bunch next and the following week so let us know how we can help!)

@vanetix

This comment has been minimized.

Copy link
Member

vanetix commented Jan 4, 2014

Awesome, I think we'll publish it once we get a few more bugs worked out. The main things missing are docs and the issue with updates. I'll can't remember what adapter tests are failing specifically, but that's what I'll start working on when I get a chance this next week.

@mikermcneil

This comment has been minimized.

Copy link
Member

mikermcneil commented Jan 6, 2014

Catching up on a few other things, but then we'll run the tests today on our end and get up to speed on everything. We'll make any changes on a branch for now and focus on docs for what's there first.

@mikermcneil

This comment has been minimized.

Copy link
Member

mikermcneil commented Jan 7, 2014

@vanetix I added a horribly annoying console.warn to registerCollection about the experimental state, and you have that warning in the readme, so afaic we can go ahead and publish it. Our team will be able to help out on this quite a bit this week to get it production ready, so I wouldn't mind stoking the fire a bit and getting some more folks playing w/ it, getting feedback etc. (as long as they know it's not ready to launch w/ yet)

@vanetix

This comment has been minimized.

Copy link
Member

vanetix commented Jan 7, 2014

That sounds good! Sorry, I've been mia working on various other non programming related things. I'll keep a lookout for updates you guys are making and try to jump in where I can

@CWyrtzen

This comment has been minimized.

Copy link

CWyrtzen commented Apr 25, 2014

More than 4 months old. Looks resolved~

@CWyrtzen CWyrtzen closed this Apr 25, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment