Low priority: Warning emitted from fs-watch-tree #288

Closed
mikermcneil opened this Issue Apr 2, 2013 · 6 comments

Comments

3 participants
@mikermcneil
Member

mikermcneil commented Apr 2, 2013

In large projects with lots of front-end files, scary-looking warning comes from fs-watch-tree when you're in development mode. See busterjs/fs-watch-tree#3 for more details.

(node) warning: possible EventEmitter memory leak detected. 11 listeners added. Use emitter.setMaxListeners() to increase limit.
Trace
    at EventEmitter.addListener (events.js:160:15)
    at /code/sails/node_modules/fs-watch-tree/lib/tree-watcher.js:74:21
    at /code/sails/node_modules/fs-watch-tree/lib/async.js:15:21
    at /code/sails/node_modules/fs-watch-tree/lib/fs-filtered.js:23:9
    at Object.oncomplete (fs.js:93:15)
(node) warning: possible EventEmitter memory leak detected. 11 listeners added. Use emitter.setMaxListeners() to increase limit.
Trace
    at EventEmitter.addListener (events.js:160:15)
    at /code/sails/node_modules/fs-watch-tree/lib/tree-watcher.js:75:21
    at /code/sails/node_modules/fs-watch-tree/lib/async.js:15:21
    at /code/sails/node_modules/fs-watch-tree/lib/fs-filtered.js:23:9
    at Object.oncomplete (fs.js:93:15)
@mikermcneil

This comment has been minimized.

Show comment
Hide comment
@mikermcneil

mikermcneil May 31, 2013

Member

This is gone in the grunt branch.

Member

mikermcneil commented May 31, 2013

This is gone in the grunt branch.

@joshua1

This comment has been minimized.

Show comment
Hide comment
@joshua1

joshua1 Jun 2, 2013

So we shouldnt worry about this? cos i have it with my durandaljs as front end project.when will it be "gone" in the other branches like master

joshua1 commented Jun 2, 2013

So we shouldnt worry about this? cos i have it with my durandaljs as front end project.when will it be "gone" in the other branches like master

@mikermcneil

This comment has been minimized.

Show comment
Hide comment
@mikermcneil

mikermcneil Jun 2, 2013

Member

It'll be fixed in 0.9, which should be released at the end of the upcoming week. What's happening is, we're using fs-watch-tree to track changes to front-end assets, and it emits that warning when it thinks it's having to watch "too many" files. Switching to grunt for our file watching solves this. So in the end, it's not causing any problems other than an unsightly error message at the moment

Member

mikermcneil commented Jun 2, 2013

It'll be fixed in 0.9, which should be released at the end of the upcoming week. What's happening is, we're using fs-watch-tree to track changes to front-end assets, and it emits that warning when it thinks it's having to watch "too many" files. Switching to grunt for our file watching solves this. So in the end, it's not causing any problems other than an unsightly error message at the moment

@OscarGodson

This comment has been minimized.

Show comment
Hide comment
@OscarGodson

OscarGodson Jul 1, 2013

I just got this. Any idea when 0.9 will be out? I actually don't have that many front-end files.

I just got this. Any idea when 0.9 will be out? I actually don't have that many front-end files.

@mikermcneil

This comment has been minimized.

Show comment
Hide comment
@mikermcneil

mikermcneil Jul 1, 2013

Member

Very soon! Trying my best. You can go ahead and start using it with:

sudo npm install -g sails@git://github.com/balderdashy/sails.git#development

And re: this warning-- it's not actually an issue, just an improperly configured event
emitter in fs-watch-tree (it's not present in production mode, since fs-watch-tree is disabled). (See the issue I reported there for more info: busterjs/fs-watch-tree#3)

Thanks for asking!

Member

mikermcneil commented Jul 1, 2013

Very soon! Trying my best. You can go ahead and start using it with:

sudo npm install -g sails@git://github.com/balderdashy/sails.git#development

And re: this warning-- it's not actually an issue, just an improperly configured event
emitter in fs-watch-tree (it's not present in production mode, since fs-watch-tree is disabled). (See the issue I reported there for more info: busterjs/fs-watch-tree#3)

Thanks for asking!

@OscarGodson

This comment has been minimized.

Show comment
Hide comment
@OscarGodson

OscarGodson Jul 1, 2013

👍

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment