New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP/2 protocol support with Sails #4228

Closed
inian opened this Issue Nov 5, 2017 · 8 comments

Comments

6 participants
@inian
Copy link

inian commented Nov 5, 2017

Sails version: v1.0.0-40
Node version: v9.0.0
NPM version: N/A
DB adapter name: N/A
DB adapter version: N/A
Operating system: All


Node.js launched with native HTTP/2 recently. HTTP/2 brings request and response multiplexing, header compression and PUSH support which will be very useful for certain kinds of applications.

All I managed to find is a feature request for integration with SPDY, but SPDY is dead.

Are there any plans of supporting HTTP/2 with Sail.js?

@sailsbot

This comment has been minimized.

Copy link

sailsbot commented Nov 5, 2017

@inian Thanks for posting, we'll take a look as soon as possible.


For help with questions about Sails, click here. If you’re interested in hiring @sailsbot and her minions in Austin, click here.

@mikermcneil

This comment has been minimized.

Copy link
Member

mikermcneil commented Nov 6, 2017

@inian Thanks for the interest! This originally came up like 5 years ago, but hadn't been something we'd seen a need for, other than out of curiosity. Now that the landscape has changed, and Node supports http2 in core, hopefully that'll change!

Since Express is a dependency of Sails, expect us to follow a similar path to Express 5. If our team or customers need http2 for an internal use case sooner than the relevant release of Express 5 is available, then it's possible we'll add a shim sooner, but I doubt that will be necessary.

btw here's a link to our updated roadmap: https://trello.com/b/s9zEnyG7

@dougwilson

This comment has been minimized.

Copy link

dougwilson commented Nov 6, 2017

I can confirm here that Express is actively working on it, and Express work has directly lead to vast changes to http2 in Node.js core itself while it was behind a flag in the early Node.js 8.x versions. HTTP/2 support is very exciting to me, and Express does fully support HTTP/2 using the "spdy" user-land module at this time. The introduction of HTTP/2 into Node.js core will bring performance improvements to the implementation of course, but has never been a blocker from using HTTP/2 with Express for the years prior to now :)

@mikermcneil

This comment has been minimized.

Copy link
Member

mikermcneil commented Nov 6, 2017

@dougwilson \o/ thanks for the update!

@inian

This comment has been minimized.

Copy link

inian commented Nov 6, 2017

@mikermcneil that's great! Other frameworks are moving ahead with supporting native HTTP/2 of Node too. Been tracking their progress too here.

@sgress454

This comment has been minimized.

Copy link
Member

sgress454 commented Nov 14, 2017

Thanks all -- closing this since it's not bug related, and we've got it tracked on the roadmap. If we drag our feet, someone will surely remind us on here again :)

@sgress454 sgress454 closed this Nov 14, 2017

@tomascharad

This comment has been minimized.

Copy link

tomascharad commented Jul 1, 2018

Hi @sgress454, how could I check the progress on this on the roadmap?
Is there any way for me to enable server push?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment