MongoIds pass integer validation whether you are using mongo or not

[kevinburkeshyp]

Relevant code in core/validations.js

    // If type is integer and the value matches a mongoID let it validate
    if(hasOwnProperty(self.validations[validation], 'type') && self.validations[validation].type === 'integer') {
      if(utils.matchMongoId(value)) return cb();
    }

So it seems like if I am using Postgres but I pass something like "4cdfb11e1f3c000000007822" as an integer value, Waterline will pass it to the database without applying the normal validation.

[devinivy]

I agree that this is smelly. We need to rip out some mongo-specific references within waterline, including this. Adapters currently do have the ability to set their own primary key type.

[johnabrams7]

@kevinburke @devinivy Hey, we moved this Mongolds issue to our main Sails hub with the label "orm." It appears to have been patched in a newer version of Waterline. Thanks for sharing this info and hope it's working for everyone now.

[kevinburke]

Great! Thanks!

[raqem]

Hi @kevinburke @devinivy we are further cleaning up the Sails issues by closing old ones and issues that have been patched with newer versions.

[johnabrams7]

This has been published.