Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot disable views hook #7043

Open
alxndrsn opened this issue Sep 23, 2020 · 2 comments
Open

Cannot disable views hook #7043

alxndrsn opened this issue Sep 23, 2020 · 2 comments

Comments

@alxndrsn
Copy link

Sails version: 1.3.1


How do you disable the views hook?

Approaches tried

.sailsrc

Adding to .sailsrc like this doesn't seem to have any effect:

"hooks": { "views":false }

User hooks

Option 1: false

Defining api/hooks/views.js as:

module.exports = false;

throw the following on npm run start:

error: Failed to lift app: TypeError: Cannot read property 'toLowerCase' of undefined
    at cant-disable-views/node_modules/include-all/lib/help-build-dictionary.js:112:43
    at cant-disable-views/node_modules/@sailshq/lodash/lib/index.js:3260:15
    at baseForOwn (cant-disable-views/node_modules/@sailshq/lodash/lib/index.js:2230:14)
    at cant-disable-views/node_modules/@sailshq/lodash/lib/index.js:3230:18
    at Function.<anonymous> (cant-disable-views/node_modules/@sailshq/lodash/lib/index.js:3533:13)
    at helpBuildDictionary (cant-disable-views/node_modules/include-all/lib/help-build-dictionary.js:54:7)
    at Function.module.exports.optional (cant-disable-views/node_modules/include-all/index.js:67:10)
    at hooksFolder (cant-disable-views/node_modules/sails/lib/hooks/moduleloader/index.js:404:22)
    at runTask (cant-disable-views/node_modules/sails/node_modules/async/dist/async.js:1621:13)
    at cant-disable-views/node_modules/sails/node_modules/async/dist/async.js:1559:13
    at processQueue (cant-disable-views/node_modules/sails/node_modules/async/dist/async.js:1569:13)
    at Object.auto (cant-disable-views/node_modules/sails/node_modules/async/dist/async.js:1555:5)
    at Hook.loadUserHooks (cant-disable-views/node_modules/sails/lib/hooks/moduleloader/index.js:401:13)
    at Hook.wrapper [as loadUserHooks] (cant-disable-views/node_modules/@sailshq/lodash/lib/index.js:3282:19)
    at Hook.initialize (cant-disable-views/node_modules/sails/lib/hooks/userhooks/index.js:23:21)
    at Hook.wrapper [as initialize] (cant-disable-views/node_modules/@sailshq/lodash/lib/index.js:3282:19)

Option 2: empty function

module.exports = () => ({});

throw the following on npm run start:

error: Failed to lift app: Error: 
    at Hook.configure (cant-disable-views/node_modules/sails-hook-sockets/lib/configure.js:60:13)
    at Hook.wrapper [as configure] (cant-disable-views/node_modules/@sailshq/lodash/lib/index.js:3282:19)
    at cant-disable-views/node_modules/sails/lib/app/private/loadHooks.js:331:20
    at cant-disable-views/node_modules/sails/node_modules/async/dist/async.js:3083:16
    at eachOfArrayLike (cant-disable-views/node_modules/sails/node_modules/async/dist/async.js:1003:9)
    at eachOf (cant-disable-views/node_modules/sails/node_modules/async/dist/async.js:1051:5)
    at Object.eachLimit (cant-disable-views/node_modules/sails/node_modules/async/dist/async.js:3145:5)
    at configure (cant-disable-views/node_modules/sails/lib/app/private/loadHooks.js:328:17)
    at cant-disable-views/node_modules/sails/node_modules/async/dist/async.js:3853:24
    at replenish (cant-disable-views/node_modules/sails/node_modules/async/dist/async.js:946:17)
    at iterateeCallback (cant-disable-views/node_modules/sails/node_modules/async/dist/async.js:931:17)
    at cant-disable-views/node_modules/sails/node_modules/async/dist/async.js:906:16
    at cant-disable-views/node_modules/sails/node_modules/async/dist/async.js:3858:13
    at cant-disable-views/node_modules/sails/node_modules/async/dist/async.js:421:16
    at iteratorCallback (cant-disable-views/node_modules/sails/node_modules/async/dist/async.js:998:13)
    at cant-disable-views/node_modules/sails/node_modules/async/dist/async.js:906:16

If the sails-hook-sockets dependency is removed, the error changes to:

error: Failed to lift app: Error: callback function required
    at Function.engine (cant-disable-views/node_modules/express/lib/application.js:295:11)
    at cant-disable-views/node_modules/sails/lib/hooks/http/initialize.js:150:24
    at cant-disable-views/node_modules/sails/lib/app/private/after.js:111:14
    at cant-disable-views/node_modules/sails/node_modules/async/dist/async.js:3861:9
    at cant-disable-views/node_modules/sails/node_modules/async/dist/async.js:421:16
    at iteratorCallback (cant-disable-views/node_modules/sails/node_modules/async/dist/async.js:998:13)
    at cant-disable-views/node_modules/sails/node_modules/async/dist/async.js:906:16
    at cant-disable-views/node_modules/sails/node_modules/async/dist/async.js:3858:13
    at handlerFn (cant-disable-views/node_modules/sails/lib/app/private/after.js:85:18)
    at cant-disable-views/node_modules/sails/node_modules/async/dist/async.js:3853:24
    at eachOfArrayLike (cant-disable-views/node_modules/sails/node_modules/async/dist/async.js:1003:9)
    at eachOf (cant-disable-views/node_modules/sails/node_modules/async/dist/async.js:1051:5)
    at _parallel (cant-disable-views/node_modules/sails/node_modules/async/dist/async.js:3852:5)
    at Object.parallelLimit [as parallel] (cant-disable-views/node_modules/sails/node_modules/async/dist/async.js:3935:5)
    at Sails.emitter.after (cant-disable-views/node_modules/sails/lib/app/private/after.js:105:11)
    at _afterLoadingSessionHookIfApplicable (cant-disable-views/node_modules/sails/lib/hooks/http/initialize.js:140:17)
@sailsbot
Copy link

@alxndrsn Thanks for posting! We'll take a look as soon as possible.

In the mean time, there are a few ways you can help speed things along:

  • look for a workaround. (Even if it's just temporary, sharing your solution can save someone else a lot of time and effort.)
  • tell us why this issue is important to you and your team. What are you trying to accomplish? (Submissions with a little bit of human context tend to be easier to understand and faster to resolve.)
  • make sure you've provided clear instructions on how to reproduce the bug from a clean install.
  • double-check that you've provided all of the requested version and dependency information. (Some of this info might seem irrelevant at first, like which database adapter you're using, but we ask that you include it anyway. Oftentimes an issue is caused by a confluence of unexpected factors, and it can save everybody a ton of time to know all the details up front.)
  • read the code of conduct.
  • if appropriate, ask your business to sponsor your issue. (Open source is our passion, and our core maintainers volunteer many of their nights and weekends working on Sails. But you only get so many nights and weekends in life, and stuff gets done a lot faster when you can work on it during normal daylight hours.)
  • let us know if you are using a 3rd party plugin; whether that's a database adapter, a non-standard view engine, or any other dependency maintained by someone other than our core team. (Besides the name of the 3rd party package, it helps to include the exact version you're using. If you're unsure, check out this list of all the core packages we maintain.)

Please remember: never post in a public forum if you believe you've found a genuine security vulnerability. Instead, disclose it responsibly.

For help with questions about Sails, click here.

@eashaw
Copy link
Member

eashaw commented Oct 5, 2020

Hi @alxndrsn, I'm not sure if there's a way to disable the view hook in your settings, but you can try taking a look at this file in Sails core where the core hooks are brought in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants