Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JellyForm dependencies #785

Merged
merged 1 commit into from Mar 21, 2019
Merged

Update JellyForm dependencies #785

merged 1 commit into from Mar 21, 2019

Conversation

cyplo
Copy link
Contributor

@cyplo cyplo commented Mar 20, 2019

  • rjsf
  • temen
  • jellyschema

@cyplo
Copy link
Contributor Author

cyplo commented Mar 20, 2019

There is some incompatibility in the ts types - looking into that.

Copy link
Contributor

@sradevski sradevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cyplo cyplo force-pushed the update-rjsf branch 2 times, most recently from 365fa3a to 1a48069 Compare March 21, 2019 09:22
@cyplo
Copy link
Contributor Author

cyplo commented Mar 21, 2019

New @types/rjsf needs new react types definitions and then there is a rabbit hole of fixing our code compat with new react TS types - let me see if we could not update the TS types for rjsf for now and have this still working - would prefer to do the TS stuff upgrade in the separate PR

@cyplo
Copy link
Contributor Author

cyplo commented Mar 21, 2019

@resin-ci retest

Bring in new developments from:

* rjsf
* temen
* jellyschema
* webpack - needed for dealing with new WASM builds

Change-type: patch
@cyplo
Copy link
Contributor Author

cyplo commented Mar 21, 2019

@resin-ci retest

1 similar comment
@nazrhom
Copy link
Contributor

nazrhom commented Mar 21, 2019

@resin-ci retest

@cyplo cyplo merged commit 976312f into master Mar 21, 2019
@cyplo cyplo deleted the update-rjsf branch March 21, 2019 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants