New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue to include empty pubnub keys for backwards compatibility #65

Merged
merged 1 commit into from Nov 6, 2018

Conversation

Projects
None yet
2 participants
@pimterry
Contributor

pimterry commented Nov 6, 2018

This ensures that API generated config includes empty pubnub keys, so existing installs of v9 CLI versions will validate API-generated config successfully.

It also relaxes the schema further, so all new installs of those specific CLI versions (v9.0.0 & v9.0.1) will allow those fields to be totally removed in future.

Change-type: patch

@pimterry pimterry requested review from Page- and thgreasi Nov 6, 2018

@Page-

Page- approved these changes Nov 6, 2018

@pimterry pimterry merged commit 3066092 into master Nov 6, 2018

14 checks passed

ResinCI/check-commits/commits Commit checks passed
Details
ResinCI/check-files/license license check passed
Details
ResinCI/check-files/readme readme check passed
Details
ResinCI/check-versionist/versionist Automatic versioning can be performed
Details
ResinCI/npm/linux-alpine-x86_64-node10
Details
ResinCI/npm/linux-alpine-x86_64-node6
Details
ResinCI/npm/linux-alpine-x86_64-node8
Details
ResinCI/npm/store-npm
Details
ResinCI/store-github/store-github Will successfully increase version on master
Details
ci/circleci: node-10 Your tests passed on CircleCI!
Details
ci/circleci: node-6 Your tests passed on CircleCI!
Details
ci/circleci: node-8 Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@pimterry pimterry deleted the undrop-pubnub branch Nov 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment