New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support api keys in resin sync #150

Merged
merged 4 commits into from May 28, 2018

Conversation

Projects
None yet
3 participants
@pimterry
Contributor

pimterry commented May 24, 2018

This should solve balena-io/balena-cli#881, and helps further our CLI MC progress generally.

Two separate commits here - one for the actual issue, and one just of changed build output that got missed in a previous PR. Much nicer if you review separately I expect.

@thgreasi

LGTM
Also found an out of scope outdated comment. If that's indeed the case, then it might worth changing it as part of this PR
See: https://github.com/resin-io-modules/resin-sync/blob/fbffb3a2efa3396eac38bafe1ee71606a129927d/lib/sync/remote-resin-io-device.coffee#L48

@pimterry

This comment has been minimized.

Contributor

pimterry commented May 28, 2018

Good spot @thgreasi, fixed

@resin-io-modules-versionbot resin-io-modules-versionbot bot merged commit ef36b73 into master May 28, 2018

5 checks passed

AutoMerges PR merging is in progress
Reviewers 2/1 review approvals met
Versionist Found all required commit footer tags
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@resin-io-modules-versionbot resin-io-modules-versionbot bot deleted the support-api-keys branch May 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment