New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refresh project with Pi4 testrun #2
Conversation
Change-type: minor Signed-off-by: Andrew Nhem <andrewn@balena.io>
I know I could just merge it myself, but I'm asking for a review bc of having solid principles/consistency, @chrisys . |
plantsaver/start.py
Outdated
@@ -20,7 +21,7 @@ | |||
print("Status code:"+plantsaver.status) | |||
|
|||
# Check if water level is too dry and that the pump wasn't on for the past 15 minutes | |||
if plantsaver.status_code == 1 and pump_count >= plantsaver.pump_delay * 6: | |||
if plantsaver.status_code == 1 and pump_count >= 6: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this intentional? Looks like removing the delay would set it to pumping every minute if the tick is 10 seconds, but even so would be better to keep the delay variable and tune that downwards rather than hard coding?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oohhh... I read that all wrong haha. I thought that I could force it to pump every 6 counts until it hit some kind of target moisture reading.
I think my approach is wrong. I'll take another look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for now; in the future this would be a good use case for testing the ability to provision dashboards using the new dashboard block. This one is heavily customised so there's no way we would be able to automatically get it right, so we need to be able to feed the custom built one into that block.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Also a candidate for the |
Adding Then your compose file can bring in influx, |
Refresh project with Pi4 testrun
Confirming that it works with Pi4, though more tests with specific kinds of plants (with specific moisture needs) required for more confidence.
Also updated how it pulls in InfluxDB and Grafana to avoid builder errors.
Change-type: patch
Signed-off-by: Andrew Nhem andrewn@balena.io