Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to alpine slim and do magic for build-essential #4

Merged
merged 1 commit into from Jul 12, 2017

Conversation

@curcuz
Copy link
Contributor

commented Jun 26, 2017

this produces a working build of around 100MB - a stunning improvement!

@curcuz curcuz added the enhancement label Jun 26, 2017
@curcuz curcuz self-assigned this Jun 26, 2017
@curcuz curcuz requested review from Page-, shaunmulligan and LucianBuzzo Jun 26, 2017
@shaunmulligan

This comment has been minimized.

Copy link

commented Jun 26, 2017

@curcuz how big is the final image? I think if you use the multi stage stuff like here https://github.com/resin-io-playground/nodejs-multistage-docker , you can probably get it to be about 70mb total

@curcuz

This comment has been minimized.

Copy link
Contributor Author

commented Jun 30, 2017

@shaunmulligan it's 100MB and in theory in this specific case my approach should lead to same result as multi-stage, unless our alpine-node base images are bigger than alpine base image + multistage-built node :)

@curcuz curcuz merged commit fb09b7c into master Jul 12, 2017
@@ -1,15 +1,17 @@
# base-image for node on any machine using a template variable,
# see more about dockerfile templates here:http://docs.resin.io/pages/deployment/docker-templates
# Note the node:slim image doesn't have node-gyp
FROM resin/%%RESIN_MACHINE_NAME%%-node:6
FROM resin/%%RESIN_MACHINE_NAME%%-alpine-node:slim

This comment has been minimized.

Copy link
@Page-

Page- Jul 12, 2017

This should be 6-slim @curcuz, otherwise it'll track the latest node version and potentially break on new major node versions

This comment has been minimized.

Copy link
@curcuz

curcuz Jul 12, 2017

Author Contributor

@Page- thanks, addressed here: #6

@curcuz curcuz deleted the alpine-diet branch Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.