Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check_localdisk: combine a few related tests into holistic local disk… #178

Merged
merged 1 commit into from Mar 23, 2020

Conversation

@xginn8
Copy link
Collaborator

xginn8 commented Feb 12, 2020

… check

Change-type: patch
Signed-off-by: Matthew McGinn matthew@balena.io

@xginn8 xginn8 requested review from wrboyce and ZubairLK as code owners Feb 12, 2020
@xginn8 xginn8 force-pushed the conglomerate-check-localdisk branch 3 times, most recently from 3e5e256 to 26599c8 Feb 12, 2020
@xginn8 xginn8 force-pushed the conglomerate-check-localdisk branch from 26599c8 to 92d6f9e Mar 10, 2020
… check

Change-type: patch
Signed-off-by: Matthew McGinn <matthew@balena.io>
@xginn8 xginn8 force-pushed the conglomerate-check-localdisk branch from 92d6f9e to 814fc64 Mar 20, 2020
@xginn8 xginn8 requested a review from shaunmulligan Mar 20, 2020
Copy link
Member

robertgzr left a comment

I assume the checks themselves have been reviewed previously (I didn't go into detail there)

otherwise this looks good :)

@xginn8 xginn8 merged commit 1d6e709 into master Mar 23, 2020
6 checks passed
6 checks passed
ResinCI/check-commits/commits Commits checks passed
Details
ResinCI/check-files/license License check passed
Details
ResinCI/check-files/readme Readme check passed
Details
ResinCI/check-versionist/versionist Automatic versioning can be performed
Details
ResinCI/store-github/store-github Will successfully increase version on master
Details
ci/circleci: build Your tests passed on CircleCI!
Details
@xginn8 xginn8 deleted the conglomerate-check-localdisk branch Mar 23, 2020
@xginn8

This comment has been minimized.

Copy link
Collaborator Author

xginn8 commented Mar 23, 2020

thanks for the review @robertgzr!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.