Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch: Update local mode #2450

Closed
wants to merge 7 commits into from
Closed

Conversation

mpous
Copy link
Contributor

@mpous mpous commented Nov 30, 2022

Updated Local Mode page.

Signed-off-by: Marc Pous (@mpous) marc@balena.io

Added a new screenshot and guided the users to the Settings section instead the Actions.
Modified the Local Mode sentence.

change-type: patch
@vipulgupta2048
Copy link
Member

Hello @mpous why don't you try giving the prefix method a try, which I mentioned to you before. Here the error is that I think change-type needs to have a C capital like Change-type

You seem to have missed the commit prefix to signify the change-type for your PR. Please read https://github.com/balena-io/docs/blob/master/CONTRIBUTING.md#creating-commits-in-line-with-semantic-versioning
Try adding a commit with a prefix as mentioned here ^

Change-type: patch
@vipulgupta2048
Copy link
Member

Hey @mpous, There needs to be a line break before the Change-type message because it needs to be in the footer of the commit message. That's what's going wrong. But, it would help if you weren't writing change-type messages this way anyway.

I am repeatedly pointing out the Contributing guide in my messages because this way of writing Change-type message in the footer of the commit leads to many errors. It has to be done in a certain way because that's what versionbot understands. Instead of committing like this, how about trying to add a prefix to your Update local-mode.md message and make it like patch: Update local-mode.md. This should be enough.

I hope this is helpful. Are there any blockers to using the change-type as a prefix to the commit heading or do let me know if the contributing guide is not clear enough for what needs to be done? Please do give it a shot, don't worry about the number of commits. I can squash that.

patch: Update local-mode page
Updating the Settings location for enabling local-mode

Change-type: patch
@vipulgupta2048
Copy link
Member

Thanks for making the required changes, any reason you chose to make the PR on a fork of this repo?

@mpous
Copy link
Contributor Author

mpous commented Dec 6, 2022

@vipulgupta2048 I'm currently doing PRs to other docs where I need to fork on my repo and PR. And this is how i proceeded. Is this ok?

@vipulgupta2048
Copy link
Member

Closed in favor of #2464

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants