Skip to content

Conversation

@vipulgupta2048
Copy link
Member

@vipulgupta2048 vipulgupta2048 commented Jan 3, 2025

Contains an additional change to resolve failing CI checks about env not being in context of args
I used this way of passing the env variable to get it into context.

Signed-off-by: Vipul Gupta (@vipulgupta2048) vipulgupta2048@gmail.com


Please make sure to read the CONTRIBUTING document before opening the PR for relevant information on contributing to the documentation. Thanks!

Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
@flowzone-app
Copy link
Contributor

flowzone-app bot commented Jan 3, 2025

Website deployed to CF Pages, 👀 preview link https://ffb15348.balenacloud-docs.pages.dev

@vipulgupta2048 vipulgupta2048 force-pushed the vipulgupta2048/upda-depend branch from ee1e2a1 to aec2a63 Compare January 6, 2025 12:03
restore-keys: cache-lychee-

- name: Set Deployment URL
run: echo "DEPLOYMENT_URL=${{ env.DEPLOYMENT_URL }}" >> $GITHUB_ENV

Check failure

Code scanning / octoscan

Expression injection, "env.**" is potentially untrusted. Error

Expression injection, "env.**" is potentially untrusted.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to make this change since we need to scan links on the staging URL. Since envs are not in the context of args, I had to find a different way to do this.

@flowzone-app flowzone-app bot enabled auto-merge January 6, 2025 12:09
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
@vipulgupta2048 vipulgupta2048 force-pushed the vipulgupta2048/upda-depend branch from aec2a63 to 79ec3ed Compare January 6, 2025 12:27
@flowzone-app flowzone-app bot merged commit c811024 into master Jan 6, 2025
53 checks passed
@flowzone-app flowzone-app bot deleted the vipulgupta2048/upda-depend branch January 6, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants