New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the /config/var endpoint to the open API #2

Merged
merged 1 commit into from Oct 26, 2018

Conversation

Projects
None yet
2 participants
@pimterry
Member

pimterry commented Oct 26, 2018

This extracts the env var config logic out of the cloud API, and reduces the existing vars down to only the supported options (no deltas).

@pimterry pimterry changed the title from WIP: Add the /config/var endpoint to the open API to Add the /config/var endpoint to the open API Oct 26, 2018

@pimterry pimterry requested review from dfunckt and thgreasi Oct 26, 2018

// Note that this list will be mutated by the cloud API to add
// extra variables as for cloud-only features.
export const SUPERVISOR_CONFIG_VAR_PROPERTIES: {

This comment has been minimized.

@dfunckt

dfunckt Oct 26, 2018

Member

I think it makes sense to move all these consts into lib/env-vars since they're really tied together.

This comment has been minimized.

@pimterry

pimterry Oct 26, 2018

Member

You're right, that makes a lot of sense, done.

@dfunckt

Looks great, just some formatting issues npm run prettify should easily fix.

WHITELISTED_NAMES,
WHITELISTED_NAMESPACES,
BLACKLISTED_NAMES,
SUPERVISOR_CONFIG_VAR_PROPERTIES,

This comment has been minimized.

@dfunckt

dfunckt Oct 26, 2018

Member

Weird spacing here. npm run prettify should be available on current master (otherwise it'll be introduced by #1).

Show resolved Hide resolved src/routes/config.ts
@pimterry

This comment has been minimized.

Member

pimterry commented Oct 26, 2018

No, seems like prettier isn't available. That's fine - I'll wait until your PR is merged, and then rebase & fix formatting.

@dfunckt

This comment has been minimized.

Member

dfunckt commented Oct 26, 2018

@pimterry I just merged #1.

Add the /config/var endpoint
Change-type: minor
@pimterry

This comment has been minimized.

Member

pimterry commented Oct 26, 2018

All prettified, merging 👍

@pimterry pimterry merged commit 5c4c2ec into master Oct 26, 2018

8 of 16 checks passed

ResinCI/npm/linux-alpine-x86_64-node10
Details
ResinCI/npm/linux-alpine-x86_64-node6
Details
ResinCI/npm/linux-alpine-x86_64-node8
Details
ResinCI/npm/linux-ubuntu-x86-node6
Details
ResinCI/npm/linux-ubuntu-x86-node8
Details
ResinCI/npm/linux-ubuntu-x86_64-node10
Details
ResinCI/npm/linux-ubuntu-x86_64-node6
Details
ResinCI/npm/linux-ubuntu-x86_64-node8
Details
ResinCI/check-commits/commits Commit checks passed
Details
ResinCI/check-files/license license check passed
Details
ResinCI/check-files/readme readme check passed
Details
ResinCI/check-versionist/versionist Automatic versioning can be performed
Details
ResinCI/docker/build
Details
ResinCI/npm/store-npm
Details
ResinCI/pr-base-is-master/base-branch Pr is against master
Details
ResinCI/store-github/store-github Will successfully increase version on master
Details

@pimterry pimterry deleted the env-var-config branch Oct 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment