Disable dev variant substitution as they have merged #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-type: patch Signed-off-by: Kyle Harding <kyle@balena.io>
|
hey @klutchell good thinking here but I don't think I've seen anyone ever use this helper - so in the cleanup with removing helpers from this repo and into an npm package, I've actually removed it: https://github.com/balena-os/test-helpers |
|
@rcooke-warwick I think it's being used in the hup suite, which is how I ended up here. |
|
@rcooke-warwick I created this helper to facilitate downloading OS images in a standardized way. It is in use. I am surprised that the hup suite run didn't fail when the helper was removed. |
|
But, the PR sounds good. |
|
@balena-ci rebase |
ghost
force-pushed
the
klutchell/remove-variants
branch
from
509a7df
to
96c1c3e
Compare
|
@balena-ci rebase |
ghost
force-pushed
the
klutchell/remove-variants
branch
from
96c1c3e
to
bc6eaa9
Compare
|
Superseded by #614 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-type: patch
Signed-off-by: Kyle Harding kyle@balena.io
See: balena-os/meta-balena#2227
Although we are still publishing both .dev and .prod variants for now, they are actually the same image going forward.
Opening as DRAFT for a couple reasons: