Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update balena-engine to 19.03 #1824

Draft
wants to merge 5 commits into
base: development
from
Draft

Conversation

@robertgzr
Copy link
Member

robertgzr commented Jan 29, 2020

Pull in the new major release that pulls in docker 19.03.x changes and update the go version to 1.12.16


Contributor checklist

Reviewer Guidelines

  • When submitting a review, please pick:
    • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
    • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
    • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)
@robertgzr robertgzr mentioned this pull request Jan 29, 2020
0 of 4 tasks complete
@robertgzr robertgzr force-pushed the rgz/balena_engine_19_03 branch from 33be1d1 to 6d7dbe8 Jan 30, 2020
@robertgzr robertgzr force-pushed the rgz/balena_engine_19_03 branch 6 times, most recently from 5dc28f9 to e74f9a1 Feb 11, 2020
@robertgzr

This comment has been minimized.

Copy link
Member Author

robertgzr commented Feb 12, 2020

I was a bit to quick. Let's fix the go 1.12 related build errors before I try to include the release candidates for 19.03.6

@ZubairLK ZubairLK force-pushed the development branch from 8d4481e to d73261e Feb 13, 2020
@robertgzr robertgzr mentioned this pull request Feb 17, 2020
5 of 5 tasks complete
robertgzr added 3 commits Jan 27, 2020
Change-type: minor
Signed-off-by: Robert Günzler <robertg@balena.io>
Pulls in the changes from yocto zeus and bumps that from 1.12.9 to
1.12.12 to get recent security patches.

Signed-off-by: Robert Günzler <robertg@balena.io>
@robertgzr robertgzr force-pushed the rgz/balena_engine_19_03 branch 3 times, most recently from 5fa6711 to 8735e7a Feb 18, 2020
Port of meta-virtualization/docker commit:
https://git.yoctoproject.org/cgit/cgit.cgi/meta-virtualization/commit/recipes-containers/docker/docker-ce_git.bb?id=e7787cb01be91d3798594687a475d5b085f29ede

Since commit applied in moby [61a3285 Support cross-compile for arm]
it hardcoded var-CC to support cross-compile for arm

Correct it with "${parameter:-word}" format, it is helpful for user
define toolchains

(Use Default Values.  If parameter is unset or null, the expansion of
word is substituted.  Otherwise, the value of parameter is substituted.)

moby/moby@61a3285
@robertgzr robertgzr force-pushed the rgz/balena_engine_19_03 branch from 8735e7a to 69d6e8d Feb 24, 2020
@robertgzr

This comment has been minimized.

Copy link
Member Author

robertgzr commented Feb 24, 2020

Fixed the cross build by applying the patch from meta-virtualization/docker

device-types on yocto older than warrior still fail with:

ERROR: Multiple versions of go-cross-aarch64 are due to be built (/yocto/resin-board/build/../layers/poky/meta/recipes-devtools/go/go-cross_1.10.bb /yocto/resin-board/build/../layers/meta-balena/meta-balena-common/recipes-devtools/go/go-cross_1.12.bb). Only one version of a given PN should be built in any given build. You likely need to set PREFERRED_VERSION_go-cross-aarch64 to select the correct version or don't depend on multiple versions.

see https://jenkins.dev.resin.io/job/yocto-cl-som-imx8/264/console

…12.12"

This reverts commit e2d920b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.