Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
qa_fir_filter_with_buffer.cc : Fix incorrect use of sizeof().
Addresses CID 1046078. sizeof the product of two numbers is wrong.
The intent is to set the actual_output vector to zero. This appears
to break QA, the test numbers need updating.

Signed-off-by: Philip Balister <philip@balister.org>
  • Loading branch information
balister committed Nov 15, 2013
1 parent 3b27cc4 commit dcdc465
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion gr-filter/lib/qa_fir_filter_with_buffer.cc
Expand Up @@ -376,7 +376,7 @@ namespace gr {
new kernel::fir_filter_with_buffer_ccf(f1_taps);

// zero the output, then do the filtering
memset(actual_output, 0, sizeof(OUTPUT_LEN*sizeof(gr_complex)));
memset(actual_output, 0, OUTPUT_LEN*sizeof(gr_complex));
f1->filterNdec(actual_output, input, ol/decimate, decimate);

// check results
Expand Down

1 comment on commit dcdc465

@mfischer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL, good shit

Please sign in to comment.