Skip to content

Loading…

uid should be stored in string. #1

Merged
merged 2 commits into from

2 participants

@albb0920

spec: https://github.com/intridea/omniauth/wiki/Auth-Hash-Schema

uid (required) - An identifier unique to the given provider, such as a Twitter user ID. Should be stored as a string.

BTW, the version in rubygems is too old, which has nil uid issue, please update it.

Thanks!

@albb0920

Also, the "uid" field is undocumented in plurk's API docs, please consider use "id" field instead, which holds the exact same numeric user id.

@ballantyne
@albb0920

I have made the uid => id change too, this is already a pull request, so please merge it and publish it to rubygems, thanks.

@ballantyne
Owner

ok, cool

@ballantyne ballantyne merged commit 4ab26b6 into ballantyne:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Showing with 1 addition and 1 deletion.
  1. +1 −1 lib/omniauth/strategies/plurk.rb
View
2 lib/omniauth/strategies/plurk.rb
@@ -22,7 +22,7 @@ def consumer
consumer
end
- uid { raw_info['uid'] }
+ uid { raw_info['id'].to_s }
info do
{
Something went wrong with that request. Please try again.