Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve tuple element identification #10267

Closed
MaryamZi opened this issue Sep 3, 2018 · 1 comment
Closed

Improve tuple element identification #10267

MaryamZi opened this issue Sep 3, 2018 · 1 comment
Labels
Area/JVMCodeGen JVM code generation module Deferred Tag tasks not addressed >1 year, moved to closed state, until addressed in the future. Team/jBallerina All the issues related to BIR, JVM backend code generation and runtime Type/Task

Comments

@MaryamZi
Copy link
Member

MaryamZi commented Sep 3, 2018

Description:
With the initial changes to the main/entry function with #10060, tuple elements are identified by splitting values at commas.

This could cause issues if the tuple elements themselves include commas. This logic needs to be improved, probably by introducing a parser for better identification.
@MaryamZi MaryamZi self-assigned this Sep 3, 2018
@MaryamZi MaryamZi added Area/JVMCodeGen JVM code generation module Type/Task labels Sep 3, 2018
@anupama-pathirage anupama-pathirage added the Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times. label Apr 30, 2019
@anupama-pathirage anupama-pathirage added Team/jBallerina All the issues related to BIR, JVM backend code generation and runtime and removed Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times. labels Aug 5, 2019
@SupunS
Copy link
Contributor

SupunS commented Sep 9, 2019

@MaryamZi Can you provide a sample where the mentioned issue can be observed?

@KavinduZoysa KavinduZoysa added this to the Ballerina 1.0.x milestone Oct 17, 2019
@KavinduZoysa KavinduZoysa added this to Needs triage in Ballerina Compiler Bug triage via automation Oct 17, 2019
@hasithaa hasithaa removed this from Needs triage in Ballerina Compiler Bug triage Nov 22, 2019
@hasithaa hasithaa removed this from the Ballerina 1.0.x milestone Jan 5, 2021
@MaryamZi MaryamZi removed their assignment Feb 24, 2022
@warunalakshitha warunalakshitha added the Deferred Tag tasks not addressed >1 year, moved to closed state, until addressed in the future. label Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area/JVMCodeGen JVM code generation module Deferred Tag tasks not addressed >1 year, moved to closed state, until addressed in the future. Team/jBallerina All the issues related to BIR, JVM backend code generation and runtime Type/Task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@hasithaa @warunalakshitha @SupunS @MaryamZi @anupama-pathirage @KavinduZoysa