Add error:StackFrame[] as a key-value pair type
#354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #354 +/- ##
============================================
+ Coverage 88.28% 88.72% +0.44%
Complexity 3 3
============================================
Files 4 4
Lines 128 133 +5
Branches 76 79 +3
============================================
+ Hits 113 118 +5
Misses 14 14
Partials 1 1
Continue to review full report at Codecov.
|
| @@ -46,5 +46,5 @@ function f2() { | |||
|
|
|||
| function f3() { | |||
| error e = error("bad sad"); | |||
| log:printDebug("debug log", stackTrace = e.stackTrace().callStack, username = "Alex92", id = 845315); | |||
| log:printDebug("debug log", stackTrace = e.stackTrace(), username = "Alex92", id = 845315); | |||
There was a problem hiding this comment.
Wouldn’t this be a breaking change?
There was a problem hiding this comment.
This is a breaking change from ballerina-lang. The error:stackTrace() function does not return a CallStack oblect. Now it returns error:StackFrame[][1].
There was a problem hiding this comment.
Let's add this to.the release note and go ahead.
niveathika
approved these changes
Nov 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes ballerina-platform/ballerina-library#2360
This change is related to the return type change of
error:stackTrace()function. For more information refer [1]. This would change the log as follows.Old log:
New log:
[1] https://github.com/ballerina-platform/ballerina-release/blob/beta4-language-changes/release-notes/swan-lake-beta4-release-note.md
Examples
Checklist