New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve error message for time types #433
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalaiyarasiganeshalingam
requested review from
daneshk and
niveathika
as code owners
November 9, 2021 13:20
Codecov Report
@@ Coverage Diff @@
## master #433 +/- ##
==========================================
- Coverage 80.57% 80.16% -0.42%
==========================================
Files 37 37
Lines 3553 3560 +7
Branches 744 744
==========================================
- Hits 2863 2854 -9
- Misses 463 481 +18
+ Partials 227 225 -2
Continue to review full report at Codecov.
|
niveathika
reviewed
Nov 9, 2021
native/src/main/java/io/ballerina/stdlib/sql/nativeimpl/ExecuteProcessor.java
Outdated
Show resolved
Hide resolved
...main/java/io/ballerina/stdlib/sql/parameterprocessor/DefaultStatementParameterProcessor.java
Outdated
Show resolved
Hide resolved
...main/java/io/ballerina/stdlib/sql/parameterprocessor/DefaultStatementParameterProcessor.java
Outdated
Show resolved
Hide resolved
niveathika
reviewed
Nov 11, 2021
...main/java/io/ballerina/stdlib/sql/parameterprocessor/DefaultStatementParameterProcessor.java
Outdated
Show resolved
Hide resolved
niveathika
approved these changes
Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
$Subject
Fixes: ballerina-platform/ballerina-library#2376
Fixes:
Examples
Checklist