Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error handling to plugins on core's level #142

Merged
merged 17 commits into from
Feb 27, 2023

Conversation

Omri-Levy
Copy link
Contributor

Description

Elaborate on the subject, motivation, and context.

Related issues

  • Provide a link to each related issue.

Breaking changes

  • Describe the breaking changes that this pull request introduces.

How these changes were tested

  • Describe the tests that you ran to verify your changes, including devices, operating systems, browsers and versions.

Examples and references

  • Links, screenshots, and other resources related to this change.

Checklist

  • [] I have read the contribution guidelines of this project
  • [] I have read the style guidelines of this project
  • [] I have performed a self-review of my own code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [] My changes generate no new warnings and errors
  • [] New and existing tests pass locally with my changes

@changeset-bot
Copy link

changeset-bot bot commented Feb 22, 2023

🦋 Changeset detected

Latest commit: 02a954f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ballerine/workflow-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Omri-Levy Omri-Levy changed the title WIP - Add error handling to plugins on core's level Add error handling to plugins on core's level Feb 26, 2023
@Omri-Levy Omri-Levy merged commit c018f88 into main Feb 27, 2023
@Omri-Levy Omri-Levy deleted the omri-levy/feat/core-error-handling branch February 27, 2023 15:08
MihirMandviwala pushed a commit that referenced this pull request Feb 12, 2024
* chore(version control): init commit for wip pr

* feat(package.json): added rimraf and a clean command for the build directory

* feat(package.json): now running pnpm clean before pnpm build

* fix(rollup.config.ts): removed the dts plugin from esm and cjs configs

otherwise there's no index.js in the output

* refactor(statecharts.ts): removed previous implementation of statePlugins

* fix(statecharts.ts): entry/exit actions injection now uses a set to avoid duplicates

* feat(statecharts.ts): added the ability to pass actions from outside into createMachine

now statePlugins are injected to a state's exit/entry as an array with unique values

* chore(changesets): added a changeset for latest changes

* ci(vite timestamp): removed vite.config.ts.timestamp file from remote

* chore(version control): init commit for wip pr

* refactor(package.json): added development packages and scripts (already in other open pr)

* chore(*): checkpoint

* feat(statecharts.ts): now subscribers are notified when a state plugin's action changes status

* chore(version control): removed build from verson control

* fix(*): removed workflow-browser-sdk from wrong branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant