Add referential actions to TableConstraint foreign key

[joshwd36]

This adds ON UPDATE and ON DELETE actions to sqlparser::ast::TableConstraint::ForeignKey, as described in table constraint and references specification.

[coveralls]

Pull Request Test Coverage Report for Build 723771861

• 35 of 41 (85.37%) changed or added relevant lines in 3 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.04%) to 90.092%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/parser.rs	10	11	90.91%
tests/sqlparser_common.rs	14	15	93.33%
src/ast/ddl.rs	11	15	73.33%

Totals
Change from base Build 676410191:	0.04%
Covered Lines:	5492
Relevant Lines:	6096

---

💛 - Coveralls

[alamb]

Hi @joshwd36 -- sorry for the delay in review. I am going to help out now with this repo and we are working to clear the backlog. Is this PR still something you would like to work on to help contribute?

[joshwd36]

Hi @joshwd36 -- sorry for the delay in review. I am going to help out now with this repo and we are working to clear the backlog. Is this PR still something you would like to work on to help contribute?

No worries at all. I do currently have a project that relies on my fork of this so it would be good to get it merged. Other than rebasing is there any other work that needs to be done on it?

[alamb]

Looks great -- thank you very much @joshwd36

I think the code looks correct 👍 . Other than rebasing, the only thing I suggest for this PR is possibly add tests for the following cases:

1. Alternate clause order ON UPDATE ... ON DELETE (I only see a test for ON DELETE .. ON UPDATE..)
2. Error: duplicated ON DELETE clause e.g. ... ON DELETE CASCADE ON DELETE CASCADE

Thoughts @Dandandan / @andygrove ?

[joshwd36]

Looks great -- thank you very much @joshwd36

I think the code looks correct 👍 . Other than rebasing, the only thing I suggest for this PR is possibly add tests for the following cases:

1. Alternate clause order `ON UPDATE ... ON DELETE` (I only see a test for `ON DELETE .. ON UPDATE..`)

2. Error: duplicated ON DELETE clause e.g. `... ON DELETE CASCADE ON DELETE CASCADE`

Thoughts @Dandandan / @andygrove ?

Sounds good. I'll see if I get a chance to do this in the next few days.

[coveralls]

Pull Request Test Coverage Report for Build 1166487596

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 50 of 55 (90.91%) changed or added relevant lines in 3 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.1%) to 90.181%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/parser.rs	10	11	90.91%
src/ast/ddl.rs	11	15	73.33%

Totals
Change from base Build 1160013514:	0.1%
Covered Lines:	5621
Relevant Lines:	6233

---

💛 - Coveralls

[alamb]

Looks great. Thanks @joshwd36