New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly resolve Android TXT records #44

Merged
merged 2 commits into from Sep 13, 2017

Conversation

Projects
None yet
2 participants
@rdev
Contributor

rdev commented Sep 12, 2017

Related to my comment in #41.
With this TXT records are resolved and logic works exactly as it did with tinydnssd in 0.8.0 so no code changes are required on the React side.

Tested on Android 7, works fine.

@balthazar

Very nice! Thank you! 😃

Would love to hear your thoughts about the locale cahnge.

Also if you don't mind to also indent the code the way it is currently? I can do it on my side otherwise.

for (String key : attributes.keySet()) {
try {
byte[] recordValue = attributes.get(key);
txtRecords.putString(String.format(Locale.US, "%s", key), String.format(Locale.US, "%s", recordValue != null ? new String(recordValue, "UTF_8") : ""));

This comment has been minimized.

@balthazar

balthazar Sep 12, 2017

Owner

Should we use Locale.getDefault() instead?

This comment has been minimized.

@rdev

rdev Sep 13, 2017

Contributor

Good point

@balthazar

This comment has been minimized.

Owner

balthazar commented Sep 13, 2017

Nice, thanks again 👍

@balthazar balthazar merged commit 7804e8d into balthazar:develop Sep 13, 2017

@balthazar balthazar referenced this pull request Oct 11, 2017

Closed

Various issues #46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment