New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSPatch.js not found in cocoapods installed version #17

Merged
merged 3 commits into from Jun 3, 2015

Conversation

Projects
None yet
2 participants
@Robert-Qiu

Robert-Qiu commented Jun 1, 2015

if use cocoapods to install JSPatch, unit test in main project will fail for JSPatch.js can not be found.
change [NSBundle mailBundle] to [NSBundle bundleForClass:] to get the path.

qiuweijia added some commits Jun 1, 2015

qiuweijia
if use cocoapods to install JSPatch, unit test in main project will f…
…ail of JSPatch.js can not be found.

change [NSBundle bundleForClass:] to get the path
qiuweijia
1. change the JPMethodImplement for only JPMETHOD_IMPLEMENTATION_RET(…
…id, id, return [ret toObject])

2. change overrideMethod logic
3. add a unit test to support above changes
@bang590

This comment has been minimized.

bang590 commented on b2423ac Jun 3, 2015

should not special handling the JPMethodImplement_id

while (!fun) {
        cls = class_getSuperclass(cls);
        if (!cls) {
            NSLog(@"warning can not find selector %@", selectorName);
        }
        clsName = NSStringFromClass(cls);
        fun = _JSOverideMethods[clsName][selectorName];
}

The code should add to every JPMethodImplement

qiuweijia
1.add the test JPMethodImplement_XXX to macro
2.add a function to get js function in object hierarchy

bang590 added a commit that referenced this pull request Jun 3, 2015

Merge pull request #17 from Robert-Qiu/master
bug fix for override super class method

@bang590 bang590 merged commit daba468 into bang590:master Jun 3, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@intheway intheway referenced this pull request Jun 25, 2015

Closed

UIAlertView crash #45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment