Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(revision): add basic response models #44

Merged
merged 3 commits into from
Dec 24, 2021

Conversation

MichaelMai2000
Copy link
Contributor

add Creator, Revision and PagedRevision models.

#28 #29 @Sociosarbis @trim21

add `Creator`, `Revision` and `PagedRevision` models.
This was referenced Dec 24, 2021
@codecov
Copy link

codecov bot commented Dec 24, 2021

Codecov Report

Merging #44 (7e5c800) into master (2b56956) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #44   +/-   ##
=======================================
  Coverage   99.12%   99.12%           
=======================================
  Files          54       54           
  Lines        2181     2181           
=======================================
  Hits         2162     2162           
  Misses         19       19           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b56956...7e5c800. Read the comment docs.

@trim21
Copy link
Contributor

trim21 commented Dec 24, 2021

这个泛型是跟List一样用的,不是用来继承的

@trim21 trim21 changed the title feat(revision): add revision generic models feat(revision): add basic response models Dec 24, 2021
& use `Optional`
can use `Paged[Revision]` instead.
@trim21 trim21 merged commit f41e95a into bangumi:master Dec 24, 2021
@MichaelMai2000 MichaelMai2000 deleted the feat-rev-model branch December 25, 2021 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants