New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix gemspec version #48

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@dai-vdr

dai-vdr commented Oct 21, 2017

T/O

@banister

This comment has been minimized.

Show comment
Hide comment
@banister

banister Oct 21, 2017

Owner

Thansk,

But is it possible to just require the version inside the gemspec and use that instead?

We do something like that here: https://github.com/pry/pry/blob/master/pry.gemspec#L2-L6

However when i do that in method_source i notice that i end up with constant redefinition warnings when running pry in method_source. Would you be able to figure out what's going on here? 👍

Owner

banister commented Oct 21, 2017

Thansk,

But is it possible to just require the version inside the gemspec and use that instead?

We do something like that here: https://github.com/pry/pry/blob/master/pry.gemspec#L2-L6

However when i do that in method_source i notice that i end up with constant redefinition warnings when running pry in method_source. Would you be able to figure out what's going on here? 👍

@dai-vdr

This comment has been minimized.

Show comment
Hide comment
@dai-vdr

dai-vdr Oct 22, 2017

Your approach is better than mine.
But i did not get constant redefinition warnings with running pry...

dai-vdr commented Oct 22, 2017

Your approach is better than mine.
But i did not get constant redefinition warnings with running pry...

@banister

This comment has been minimized.

Show comment
Hide comment
@banister

banister Oct 22, 2017

Owner

@dai-vdr turns out we have a rake task that does this automatically: rake gemspec so i just ran that and then committed it

Owner

banister commented Oct 22, 2017

@dai-vdr turns out we have a rake task that does this automatically: rake gemspec so i just ran that and then committed it

@banister banister closed this Oct 22, 2017

@banister banister reopened this Oct 22, 2017

@banister banister closed this Oct 22, 2017

@dai-vdr

This comment has been minimized.

Show comment
Hide comment
@dai-vdr

dai-vdr Oct 22, 2017

thanks! 👍

dai-vdr commented Oct 22, 2017

thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment