Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

USE_PLYMOUTH=1 environment to control plymouth activation #5

Closed
erikh opened this Issue · 10 comments

2 participants

@erikh

It'd be nice to have something like this for non-interactive runs so they just get the "normal" system and I can still get plymouth without having to modify numerous test files each time I want to use plymouth.

@banister
Owner

so this means it's off by default, and users have to explicitly turn it on to use it?

@banister banister closed this issue from a commit
@banister Use environment variable USE_PLYMOUTH, fixes #5
* plymouth will not run if USE_PLYMOUTH is set to "false", "0", or "no"
bbca210
@banister banister closed this in bbca210
@banister
Owner

Is this reasonable? bbca210

I defaulted to plymouth being active by default, and users have to explicitly disable it using USE_PLYMOUTH=0 (or false or no)

@erikh

I think that will still cause problems with CI systems because it's on by default.

@banister
Owner

I think that if it's off by default, it creates a potentially annoying barrier to entry as people have to then explicitly export USE_PLYMOUTH=1 before it starts working, any other solutions?

btw have you used it much? im getting approximately 0 feedback from people so i have no idea if it's working or segfaulting, or just behaving weird :)

@erikh

No ideas -- maybe a text file they can put in .gitignore?

Not yet -- I'll give it a shot when I work on projects this weekend.

@banister
Owner

ah good point about travis and friends, i hadnt thought of that hmmm

@banister
Owner

what about if they turn it off/on in their projects local .pryrc ? Plymouth.disable!

@erikh

works for me

@banister
Owner

@erikh actually i just spoke to a dude and he said, regarding the travis issue, you could simply set env: RUN_PLYMOUTH="no" inside .travis.yml is this enough?

@erikh

Sounds awesome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.