Use atty crate instead of libc #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The specific reason for this is to make the crate run on Redox OS (it is needed as a dependency of something). And it just generally seems like a good idea. @banyan Does this seem reasonable? |
|
Ping @banyan; I'd like to get a program (specifically uutils) that uses this library to run on Redox without modifying Cargo.toml. Tell me if you'd prefer a different way to get it running on Redox. |
|
sorry for late and thanks for the changes! 🙇 |
|
Released as 0.2.1! |
|
Thanks! |
|
Uh, crates.io still says last updated "10 months ago", and the download doesn't seem to have this change. |
|
oh, sorry. I'll fix now. |
|
sorry, I had to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids direct use of anything platform specific, and is a reduction in code (not counting the generated Cargo.lock).