New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use atty crate instead of libc #4

Merged
merged 1 commit into from Sep 25, 2017

Conversation

Projects
None yet
2 participants
@ids1024
Contributor

ids1024 commented Jul 25, 2017

This avoids direct use of anything platform specific, and is a reduction in code (not counting the generated Cargo.lock).

@ids1024

This comment has been minimized.

Contributor

ids1024 commented Aug 7, 2017

The specific reason for this is to make the crate run on Redox OS (it is needed as a dependency of something). And it just generally seems like a good idea.

@banyan Does this seem reasonable?

@ids1024

This comment has been minimized.

Contributor

ids1024 commented Sep 24, 2017

Ping @banyan; I'd like to get a program (specifically uutils) that uses this library to run on Redox without modifying Cargo.toml. Tell me if you'd prefer a different way to get it running on Redox.

@banyan

This comment has been minimized.

Owner

banyan commented Sep 25, 2017

@ids1024

sorry for late and thanks for the changes! 🙇

@banyan banyan merged commit 487d87b into banyan:master Sep 25, 2017

@banyan

This comment has been minimized.

Owner

banyan commented Sep 25, 2017

@ids1024

Released as 0.2.1!

@ids1024

This comment has been minimized.

Contributor

ids1024 commented Sep 26, 2017

Thanks!

@ids1024

This comment has been minimized.

Contributor

ids1024 commented Sep 30, 2017

Uh, crates.io still says last updated "10 months ago", and the download doesn't seem to have this change.

@banyan

This comment has been minimized.

Owner

banyan commented Oct 2, 2017

@ids1024

oh, sorry. I'll fix now.

@banyan

This comment has been minimized.

Owner

banyan commented Oct 2, 2017

sorry, I had to use cargo publish. Now uploaded as 0.2.2: https://crates.io/crates/pretty-bytes
🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment