Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the ability to set custom labels on metrics #85

Open
jnovick opened this issue Dec 19, 2022 · 0 comments
Open

Adding the ability to set custom labels on metrics #85

jnovick opened this issue Dec 19, 2022 · 0 comments

Comments

@jnovick
Copy link

jnovick commented Dec 19, 2022

Is your feature request related to a problem? Please describe.
When creating batches of jobs, I want the batch number to be a label on the same metric not a part of the metric name. This will make it easier to report both individual batches and all batches over a given time.

Describe the solution you'd like to see
Something like this: #19 (comment)

If you look at the Prometheus best practices, specifically the documentation about the data model and the part about Metric and label naming, you'll see that Prometheus advocates using more generic metric names

I know I can set labels statically using *.sink.<your-sink>.labels=label1=value1,label2=value2 but I want to apply labels where the value is determined at runtime.

Describe alternatives you've considered
I can continue to make the metric name longer by adding to the accumulator, but it would be more in line with Prometheus best practices to use job labels.

Additional context
None that I can think of

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant