Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make tzdb an optional dependency #112

Merged
merged 1 commit into from
Aug 17, 2022
Merged

Conversation

davidkna
Copy link
Contributor

This improves the minimum supported rust version a bit, and can be used in cases where having access to the local timezone is less important.

@baoyachi
Copy link
Owner

@davidkna Thx. It's cool

@baoyachi baoyachi merged commit baf1698 into baoyachi:master Aug 17, 2022
@baoyachi
Copy link
Owner

baoyachi commented Aug 17, 2022

@davidkna
I want tell you add tzdb crate context. I tried the method you provided before, but the run MacOS returned error, I found that tzdb solved this problem, so I used tzdb at present, the timeliness of TZDB will be more accurate.

So,I add some description in code .

+ // Warning: Attempt to create a new OffsetDateTime with the current date and time in the local offset. If the offset cannot be determined, an error is returned.
+// At present, using it on MacOS return error. Use it with careful.
+// Suggestion use feature tzdb crate exposed function at below.

// Warning: Attempt to create a new OffsetDateTime with the current date and time in the local offset. If the offset cannot be determined, an error is returned.
// At present, using it on MacOS return error. Use it with careful.
// Suggestion use feature tzdb crate exposed function at below.

I can open this function, but developers need to know this problem.

@davidkna davidkna deleted the tzdb-opt branch August 17, 2022 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants