Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nightly linter #123

Merged
merged 2 commits into from
Dec 14, 2022
Merged

Fix nightly linter #123

merged 2 commits into from
Dec 14, 2022

Conversation

sameo
Copy link
Contributor

@sameo sameo commented Dec 14, 2022

See https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args

And re-enable the nightly CI as it should pass now.

sameo added a commit to sameo/attestation-service that referenced this pull request Dec 14, 2022
shadow_rs makes clippy fail. We could re-enable it once
baoyachi/shadow-rs#123 is merged.

Signed-off-by: Samuel Ortiz <sameo@rivosinc.com>
@baoyachi
Copy link
Owner

Thx @sameo . The previous comment part of the code, it seems that I was too negligent and ignored them, thank you very much

@baoyachi baoyachi merged commit ade5c2e into baoyachi:master Dec 14, 2022
sameo added a commit to sameo/attestation-service that referenced this pull request Dec 14, 2022
crates.io shadow_rs makes clippy fail, but this is fixed with
baoyachi/shadow-rs#123 and
baoyachi/shadow-rs#124.

Signed-off-by: Samuel Ortiz <sameo@rivosinc.com>
sameo added a commit to confidential-containers/attestation-service that referenced this pull request Dec 16, 2022
crates.io shadow_rs makes clippy fail, but this is fixed with
baoyachi/shadow-rs#123 and
baoyachi/shadow-rs#124.

Signed-off-by: Samuel Ortiz <sameo@rivosinc.com>
Xynnn007 pushed a commit to Xynnn007/kbs that referenced this pull request Nov 10, 2023
crates.io shadow_rs makes clippy fail, but this is fixed with
baoyachi/shadow-rs#123 and
baoyachi/shadow-rs#124.

Signed-off-by: Samuel Ortiz <sameo@rivosinc.com>
Xynnn007 pushed a commit to confidential-containers/trustee that referenced this pull request Nov 10, 2023
crates.io shadow_rs makes clippy fail, but this is fixed with
baoyachi/shadow-rs#123 and
baoyachi/shadow-rs#124.

Signed-off-by: Samuel Ortiz <sameo@rivosinc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants