Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Current develop dependencies broken #599

Closed
finwe opened this issue May 27, 2021 · 5 comments
Closed

[BUG] Current develop dependencies broken #599

finwe opened this issue May 27, 2021 · 5 comments
Labels
needs investigation This will be tested / debugged or checked out.

Comments

@finwe
Copy link

finwe commented May 27, 2021

Environment (please complete the following information):

  • PHP IMAP version: dev-develop
  • PHP Version: 8.0.5
  • Type of execution: CLI with composer

Describe the bug

Current definition of PHP requirements are broken with current set of dependencies, Composer won't install.

For dependencies to support PHP 8, minimal PHP requirement has to be risen up to ^7.4, as tested in a fork finwe@dce42bc

To Reproduce

  • Checkout develop branch
  • Run composer update with PHP 8
  Problem 1
    - Root composer.json requires sebastian/phpcpd ^4.1 -> satisfiable by sebastian/phpcpd[4.1.0].
    - sebastian/phpcpd 4.1.0 requires php ^7.1 -> your php version (8.0.5) does not satisfy that requirement.
  Problem 2
    - maglnet/composer-require-checker 2.0.0 requires php ^7.1 -> your php version (8.0.5) does not satisfy that requirement.
    - maglnet/composer-require-checker 2.1.0 requires php ^7.2 -> your php version (8.0.5) does not satisfy that requirement.
    - Root composer.json requires maglnet/composer-require-checker ^2.0 -> satisfiable by maglnet/composer-require-checker[2.0.0, 2.1.0].
@finwe finwe added the needs investigation This will be tested / debugged or checked out. label May 27, 2021
@finwe finwe mentioned this issue May 27, 2021
@bapcltd-marv
Copy link
Contributor

bapcltd-marv commented May 27, 2021

fixing the developer dependencies now, dropping php 7.2 is not necessary.

bapcltd-marv added a commit to bapcltd/php-imap that referenced this issue May 27, 2021
@bapcltd-marv bapcltd-marv mentioned this issue May 27, 2021
@finwe
Copy link
Author

finwe commented May 27, 2021

So you are installing locked dependencies in versions not officially supported in higher PHP? Not what I would do, but I guess it's OK for dev dependencies.

@bapcltd-marv
Copy link
Contributor

So you are installing locked dependencies in versions not officially supported in higher PHP? Not what I would do, but I guess it's OK for dev dependencies.

All I did was run composer require for each of the problematic dependencies & made note to append the version constraints, not sure where you get the "not officially supported" thing from.

@finwe
Copy link
Author

finwe commented May 27, 2021

Oh, I see the commit now, sorry.

aragon999 pushed a commit to aragon999/php-imap that referenced this issue Jun 13, 2021
Sebbo94BY pushed a commit that referenced this issue Dec 14, 2021
@Sebbo94BY
Copy link
Collaborator

This should be fixed now.

This change is included in the release 4.3.0 and newer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs investigation This will be tested / debugged or checked out.
Projects
None yet
Development

No branches or pull requests

3 participants